923843 - Bug 922847 broke TabsToolbar-related styling for tabsonbottom on Windows with compositor

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[:Gijs (out for now; he/him)]

Bug 922847 broke styling in browser-aero.css and indicator-aero.css for -moz-windows-compositor cases, because the tabstoolbar is no longer the last child of the tabstoolbar.

Comment 1

[:Gijs (out for now; he/him)]

(In reply to :Gijs Kruitbosch from comment #1)
> Bug 922847 broke styling in browser-aero.css and indicator-aero.css for
> -moz-windows-compositor cases, because the tabstoolbar is no longer the last
> child of the tabstoolbar.

child of the toolbox. I need sleep. :|

Comment 2

[Dão Gottwald [:dao]]

Gijs, can we expect a fix for this soon? (I think that would involve moving the indicator thingy somewhere else entirely, because it really shouldn't be a child of the toolbox.)

Need to back out the offending patch otherwise. This isn't the kind of regression we want to tolerate on central.

Comment 3

[:Gijs (out for now; he/him)]

(In reply to Dão Gottwald [:dao] from comment #2)
> Gijs, can we expect a fix for this soon? (I think that would involve moving
> the indicator thingy somewhere else entirely, because it really shouldn't be
> a child of the toolbox.)
> 
> Need to back out the offending patch otherwise. This isn't the kind of
> regression we want to tolerate on central.

If you tell me where you would like this instead of the toolbox, I can get you a patch today. I felt the toolbox was logical, seeing as that's where the button is...

I also, still, don't understand what the point of the :last-child part of the selector is.

Comment 4

[Dão Gottwald [:dao]]

(In reply to :Gijs Kruitbosch from comment #3)
> If you tell me where you would like this instead of the toolbox, I can get
> you a patch today. I felt the toolbox was logical, seeing as that's where
> the button is...

#mainPopupSet?

> I also, still, don't understand what the point of the :last-child part of
> the selector is.

I haven't looked and don't know it offhand. It might indeed be something to fix, but still toolboxes should only contain toolbars. Breaking this assumption could be a problem for various code dealing with toolbars, like toolbar customization code.

Comment 5

[:Gijs (out for now; he/him)]

Attachment: fix styling by moving the downloads animation element out of the toolbox,

A quick test seems to have this work fine.

Comment 6

[:Gijs (out for now; he/him)]

https://hg.mozilla.org/integration/fx-team/rev/46119ef89b68

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/46119ef89b68