923884 - Wrong value in markup view

Status: VERIFIED FIXED

(DevTools :: Inspector, defect)

Description

[Alice0775 White]

Steps to Reproduce:
1. Open URL
2. Inspect Element
   --- observe value of attribute

Actual Results:
color code value displays instead of plain text.

<div id="#F00" class="#00F" title="#FFF"></div>

Expected Results:
Should not convert the value.
<div id="red" class="green" title="blue"></div>

Comment 1

[Alice0775 White]

Regression window(fx-team)
Good:
http://hg.mozilla.org/integration/fx-team/rev/184a0076278b
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20130917075536
Bad:
http://hg.mozilla.org/integration/fx-team/rev/220ce292a894
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 ID:20130917084033
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=184a0076278b&tochange=220ce292a894

Suspect:
e4e9ca3868d3	Michael Ratcliffe — Bug 911748 - Add default color dropdown to devtools options panel. r=jwalker

Comment 2

[Alice0775 White]

err:

Actual Results:
<div id="#F00" class="#008000" title="#00F"></div>

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I'll take this as we have decided not to translate color values in the markup view ... people expect to see the authored string.

Comment 4

[cheesypoof]

Am I right in thinking the issue (inherit is replaced) in http://jsfiddle.net/YjPXm/2/ is this bug as well?

Link contents:
HTML: <div style="font-family: inherit;">Inspect This</div>
CSS: div { font-family: inherit; }

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

(In reply to Shaun from comment #4)
> Am I right in thinking the issue (inherit is replaced) in
> http://jsfiddle.net/YjPXm/2/ is this bug as well?
> 
> Link contents:
> HTML: <div style="font-family: inherit;">Inspect This</div>
> CSS: div { font-family: inherit; }

It is the same issue but needs addressing separately so I have logged bug 924136 for this.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: wrong-value-in-markup-view-923884.patch

Very simple patch removes color conversions from markup-view.js and browser_inspector_markup_colorconversion.js as we no longer need it.

Now we always use colors as authored in the markup view.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/153382a5ea88

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/153382a5ea88

Comment 12

[Mardeg]

I should submit this to Randy's million dollar challenge as proof of my ability to travel backwards in time, if only by half an hour.

Comment 13

[Tracy Walker [:tracy]]

verified with Nightly build 20131024030204