924097 - Geolocation test failures (test_timerRestartWatch.html) caused by the fix for bug 684722

Status: RESOLVED INACTIVE

(Core :: DOM: Geolocation, defect)

Description

[mjh563]

The proposed fix for bug 684722 has exposed an issue with the testing system that causes some mochitests that use stop_geolocationProvider to fail.

This happens because stop_geolocationProvider doesn't actually stop the provider making XHR calls, it just causes the server to return an empty response. Currently the provider ignores these empty responses, but in bug 684722 it will (correctly) notify an error back to the Geolocation service.

This causes timeout tests like test_timerRestartWatch.html to fail, because they assume that after calling stop_geolocationProvider, no further notifications will be sent from the provider.

The solution is to stop the provider making XHR calls in this situation. For example, it could check if testing is enabled and the URL contains "?action=stop-responding", and if so then not run the XHR.

Comment 1

[Josh Matthews [:jdm]]

We might be able to work around this by calling `response.processAsync()` before returning. I think this should keep the connection open and avoid sending a response, allowing for the timeout to be called.

Comment 2

[:garvan]

If this is still happening we can re-open, but based on the age and lack of activity I'll mark this inactive.