Context Menu opening inside collection and search results

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: evyatar, Assigned: evyatar)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

STR:
1. Tap to open a Collection
2. Tap and Hold on an empty area inside the collection

Result:
The home screen's context menu is shown.

Expected:
Nothing should happen. Context menu should only be shown when tap-and-holding on the home screen.
Created attachment 814122 [details]
Patch - redirect to github PR

Simply stopping propagation of contextmenu event on evme pages.

Note I also fixed a missing DIV in one of the HTML elements, to properly see it pass "w=1" to the GH compare view to ignore white spaces.
https://github.com/mozilla-b2g/gaia/pull/12711/files?w=1
Attachment #814122 - Flags: review?(ran)
Attachment #814122 - Flags: review?(crdlc)
Comment on attachment 814122 [details]
Patch - redirect to github PR

Good catch
Attachment #814122 - Flags: review?(crdlc) → review+
Attachment #814122 - Flags: review?(ran) → review+
merged to master
bdb008723ac845b36584b44a9876b95379041449

https://github.com/mozilla-b2g/gaia/commit/bdb008723ac845b36584b44a9876b95379041449
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.