924111 - localized addon's preferences stops working after disable button is pressed

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P2)

Description

[backy0175]

Attachment: Screenshots - Add-ons Manager

I am testing localized addon's preferences and found a problem.
once addon disabled, localized addon's preferences stops working
until reboot Firefox.

here are steps to reproduce problem.

test1: enable -> disable -> enable -> reboot Firefox
start Firefox
open Add-ons Manager
press options button -> displyed localized preferences
press disable
press enable -> displayed NOT localized prefences
stop Firefox
start Firefox
open Add-ons Manager
press options button -> displyed localized preferences

test2: disabled -> enable
start Firefox
open Add-ons Manager
press options button -> displyed localized preferences
press disable
stop Firefox
start Firefox
open Add-ons Manager
press enable -> displayed localized preferences

Comment 1

[Loic]

Can you attach a minimal add-on to test, please.

Comment 2

[backy0175]

Attachment: test-for-locale added some locale json files manually.xpi

Hi Loic.
Thank you for your respond and I'm sorry at the lack of information.

I attached my test addon that created Add-on Builder and add some locale json files manually.

Background:
1. Add-on Builder do not support localizable addon.
mozilla Add-ons Forum "Can't build localizable addons on Add-on Builder"
https://forums.mozilla.org/addons/viewtopic.php?f=27&t=14535

2. I'm trying to find a way to create localizable addon with Add-on Builder.

3. I checked inside l10n modules on Add-on SDK, then I found Add-on SDK is using some json files to support localization.

4. I added some locale json files into addon package file(xpi)
my-addon/		
	data
	lib
	locale/
		en-US.json
		it.json
		ja-JP.json
	locales.json

5. This works fine. But localized addon's preferences stops working after disable button is pressed.

Comment 3

[backy0175]

I did additional tests and found a cause.
This problem is happen ONLY on my Firefox environment for development.

What I did.
Test3. Create test addon by cfx. -> happened same problem.
Test4. Do locale test on other (more clean) Firefox environment. -> NOT happend this problem.

I'm sorry for taking your time.
backy0175

Comment 4

[backy0175]

I'm still fighting with this problem. :-(

Test5:
Create new profile on my Firefox environment for development.
Install locale test addon which was built by cfx -> still happend same problem.

Test6:
Disalbe all plugins on new profile -> still happend same problem.

Comment 5

[Loic]

Moving to Add-on SDK, I guess it's a better component.

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Needinfoing Dave to remind him to find that other bug to set up the dependency.

Comment 7

[Dave Townsend [:mossop]]

This is likely because the localisation code is asynchronous but the add-ons manager expects the add-on to initialise synchronously. We'd need that to be fixed first before we could fix this.

Comment 8

[backy0175]

I see.
It is seemed to have stopped working because it is asynchronous.
Then fixed this problem by close and re-open Add-ons Manager.

Test6:
open Add-ons Manager
disable addon
enable addon -> displayed NOT localized prefences
close Add-ons Manager
open Add-ons Manager
press options button -> displyed localized preferences

Comment 9

[backy0175]

Correction.

> Then fixed this problem by close and re-open Add-ons Manager.

Then avoid this problem by close and re-open Add-ons Manager.

Comment 10

[Dave Townsend [:mossop]]

Yeah that matches what I'd expect.  We might be able to hack around this by forcing the add-ons manager to refresh after the localisation info is loaded.

Comment 11

[Erik Vold [:erikvold] (please needinfo? me)]

I'm going to take a look at this one, it seems odd.

Comment 12

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562