924121 - crash in mozilla::ipc::MessageChannel::OnMaybeDequeueOne()

Status: VERIFIED FIXED

(Core :: IPC, defect)

Description

[Tracy Walker [:tracy]]

This bug was filed from the Socorro interface and is 
report bp-00a2ecd0-3c18-44f6-8aca-536f62131006.
=============================================================

This crash began happening on 20130929030202 Nightly and has climbed up to #8 on crash list.

nothing of note in correlations or URLs

Comment 1

[Benjamin Smedberg]

This may just be a changed signature of RPCChannel being renamed to MessageChannel, *but* we fixed the majority of that crash in bug 800347. Can you check for matching signatures before, and also provide a regression range if this is a new crash? There have been several IPC changes that landed recently, IIRC.

Comment 2

[Tracy Walker [:tracy]]

This signature is currently #4 on Nightly.

Investigating further, I don't think this morphed from bug 800347 - crash in mozilla::ipc::RPCChannel::OnMaybeDequeueOne. Tthe fix there and the first appearance of this signature don't match.

regression range (based on first appearance of this signature) - http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=2f4397db1830&tochange=8f805d3ef377

Comment 3

[Benjamin Smedberg]

Bug 901789 is the clear suspect. dvander can you take of investigating and possibly backing that patch out in the meantime?

Comment 4

[Benjamin Smedberg]

It appears that the new MessageChannel::~MessageChannel doesn't call Clear() at all, even though both AsyncChannel and RPCChannel used to.

I'm also a little confused about the patch http://hg.mozilla.org/mozilla-central/rev/9cc90a4b6475 because it looks like AsyncChannel.cpp still exists, but is not built.

Comment 5

[David Anderson [:dvander] - inactive, e-mail if emergency]

Yeah I'm not sure how that happened. I was very careful to include your changes in the final patch. Something must have gone wrong in between. Easy to fix though.

Comment 6

[David Anderson [:dvander] - inactive, e-mail if emergency]

Attachment: fix-merge-fail.patch

Comment 7

[Tracy Walker [:tracy]]

topcrash is being replaced by more precise keywords per https://bugzilla.mozilla.org/show_bug.cgi?id=927557#c3

Comment 8

[David Anderson [:dvander] - inactive, e-mail if emergency]

Sorry about that. Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/be0d4775e0ff

Comment 9

[Robert Kaiser]

This landed on m-c but for some reason wasn't marked correctly.

http://hg.mozilla.org/mozilla-central/rev/be0d4775e0ff

Comment 10

[Tracy Walker [:tracy]]

this signature no longer appears at all on the topcrash list for 27