Closed
Bug 924133
Opened 11 years ago
Closed 11 years ago
Remove Android WebApps build preprocessing
Categories
(Firefox for Android Graveyard :: Web Apps (PWAs), defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: nalexander, Assigned: nalexander)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
104.29 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
8.50 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
The build system has some ad-hoc configurable code to adjust the maximum number of installable webapps. We aren't going to change this frequently enough to justify the special rules, and it complicates supporting IDE builds (Eclipse, IntelliJ) significantly. Time to get rid of it!
Assignee | ||
Comment 1•11 years ago
|
||
The existing code is flexible but will be rarely updated and complicates the build system and IDE integration.
Attachment #814146 -
Flags: review?(wjohnston)
Comment 2•11 years ago
|
||
Comment on attachment 814146 [details] [diff] [review] Remove Android WebApps preprocessing. r=wesj Review of attachment 814146 [details] [diff] [review]: ----------------------------------------------------------------- Seems good
Attachment #814146 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 3•11 years ago
|
||
The existing code complicates the build system and IDE integration. This keeps most of the flexibility while simplifying the build system.
Attachment #815089 -
Flags: review?(wjohnston)
Updated•11 years ago
|
Attachment #815089 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/61f2d082139d
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/61f2d082139d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•