Closed Bug 924133 Opened 7 years ago Closed 7 years ago

Remove Android WebApps build preprocessing

Categories

(Firefox for Android :: Web Apps (PWAs), defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 27

People

(Reporter: nalexander, Assigned: nalexander)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

The build system has some ad-hoc configurable code to adjust the maximum number of installable webapps.  We aren't going to change this frequently enough to justify the special rules, and it complicates supporting IDE builds (Eclipse, IntelliJ) significantly.  Time to get rid of it!
The existing code is flexible but will be rarely updated and
complicates the build system and IDE integration.
Attachment #814146 - Flags: review?(wjohnston)
Blocks: ide
Comment on attachment 814146 [details] [diff] [review]
Remove Android WebApps preprocessing. r=wesj

Review of attachment 814146 [details] [diff] [review]:
-----------------------------------------------------------------

Seems good
Attachment #814146 - Flags: review?(wjohnston) → review+
The existing code complicates the build system and IDE integration.
This keeps most of the flexibility while simplifying the build system.
Attachment #815089 - Flags: review?(wjohnston)
Attachment #815089 - Flags: review?(wjohnston) → review+
Assignee: nobody → nalexander
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/61f2d082139d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.