924181 - Don't draw the toolbar background for navigator-toolbox if drawing tabs in titlebar

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

There's a moz-appearance: toolbar rule on the navigator-toolbox (on the ::before pseudoelement) that was used to draw the gradient behind the tabstrip.

With Australis, this gradient is superfluous if the tabs are in the titlebar, since the titlebar's -moz-appearance: -moz-window-titlebar becomes the "background" of the tabstrip.

The only case where this moz-appearance: toolbar might be useful is if the tabs are not being drawn in the titlebar.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1

Only apply the gradient if we're not drawing the tabs in the titlebar.

Gijs, are you comfortable reviewing this?

Comment 2

[:Gijs (he/him)]

Comment on attachment 814185 [details] [diff] [review]
Patch v1

Can we save ourselves some typing/understanding with:

:not(:-moz-any([privatebrowsingmode=temporary],[customizing],[customize-exiting],[tabsintitlebar]))

or does life not work that way (for either perf or CSS syntactical reasons)?

Either way, r=me.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Oh, yes, I think I like that much better. Testing indicates that this works. :) Thanks Gijs.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Attachment: Patch v1.1 (r+'d by Gijs)

Thanks Gijs!

Landed on UX as https://hg.mozilla.org/projects/ux/rev/086d470fb5f4

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/086d470fb5f4