Closed Bug 924181 Opened 11 years ago Closed 10 years ago

Don't draw the toolbar background for navigator-toolbox if drawing tabs in titlebar

Categories

(Firefox :: Theme, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: mconley)

References

Details

(Keywords: perf, Whiteboard: [Australis:P1][Australis:M9])

Attachments

(1 file, 1 obsolete file)

There's a moz-appearance: toolbar rule on the navigator-toolbox (on the ::before pseudoelement) that was used to draw the gradient behind the tabstrip.

With Australis, this gradient is superfluous if the tabs are in the titlebar, since the titlebar's -moz-appearance: -moz-window-titlebar becomes the "background" of the tabstrip.

The only case where this moz-appearance: toolbar might be useful is if the tabs are not being drawn in the titlebar.
Attached patch Patch v1 (obsolete) — Splinter Review
Only apply the gradient if we're not drawing the tabs in the titlebar.

Gijs, are you comfortable reviewing this?
Attachment #814185 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 814185 [details] [diff] [review]
Patch v1

Can we save ourselves some typing/understanding with:

:not(:-moz-any([privatebrowsingmode=temporary],[customizing],[customize-exiting],[tabsintitlebar]))

or does life not work that way (for either perf or CSS syntactical reasons)?

Either way, r=me.
Attachment #814185 - Flags: review?(gijskruitbosch+bugs) → review+
Oh, yes, I think I like that much better. Testing indicates that this works. :) Thanks Gijs.
Thanks Gijs!

Landed on UX as https://hg.mozilla.org/projects/ux/rev/086d470fb5f4
Attachment #814185 - Attachment is obsolete: true
Attachment #814195 - Flags: review+
Whiteboard: [Australis:P1][Australis:M9][fixed-in-ux]
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/086d470fb5f4
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P1][Australis:M9][fixed-in-ux] → [Australis:P1][Australis:M9]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.