Closed Bug 924248 Opened 6 years ago Closed 6 years ago

Make nsIDocument.h go on a diet

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: Ehsan, Assigned: Ehsan)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Comment on attachment 814251 [details] [diff] [review]
Patch (v1)

The cached encoder bits might be perf-sensitive.  Make sure to measure!
(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 814251 [details] [diff] [review]
> Patch (v1)
> 
> The cached encoder bits might be perf-sensitive.  Make sure to measure!

That's only used in Element::GetMarkup.  Would a micro-benchmark test case which measures innerHTML performance in a loop be enough here?
Yes, it would.  Esp for the case when an element has no kids.
Attached file Microbenchmark
This patch does not move the needle on this small testcase.
Attachment #814251 - Flags: review?(jst) → review+
https://hg.mozilla.org/mozilla-central/rev/1c7428ab1e13
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.