924248 - Make nsIDocument.h go on a diet

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

https://tbpl.mozilla.org/?tree=Try&rev=73eaab197dc4

Comment 1

[(no longer active)]

https://tbpl.mozilla.org/?tree=Try&rev=bcc28d38a76c

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 814251 [details] [diff] [review]
Patch (v1)

The cached encoder bits might be perf-sensitive.  Make sure to measure!

Comment 3

[(no longer active)]

(In reply to Boris Zbarsky [:bz] from comment #2)
> Comment on attachment 814251 [details] [diff] [review]
> Patch (v1)
> 
> The cached encoder bits might be perf-sensitive.  Make sure to measure!

That's only used in Element::GetMarkup.  Would a micro-benchmark test case which measures innerHTML performance in a loop be enough here?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yes, it would.  Esp for the case when an element has no kids.

Comment 5

[(no longer active)]

Attachment: Microbenchmark

This patch does not move the needle on this small testcase.

Comment 6

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1c7428ab1e13

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1c7428ab1e13