Closed Bug 924267 Opened 11 years ago Closed 11 years ago

refactor rabbitmq/crashstorage new_crashes method

Categories

(Socorro :: Backend, task)

Product:
Socorro
Component:
Backend
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: rhelmer, Assigned: rhelmer)

Details

I was reading through the source to understand it better, and did some minor refactoring of this method, to make it more idiomatic/readable and shorter. Really this wants a "do-while" which is in itertools but is ugly, I think the idiomatic way to do this in python is with a "while True:" and break when the predicate does not hold. Also, it would be nice to remove the magick numbers (data[0], data[2]) and use names instead.
r? selena/brandon/peterbe https://github.com/mozilla/socorro/pull/1563
Status: NEW → ASSIGNED
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/6985ead0a574e9d2cc841bc71f6924eab36889fb fixes bug 924267 - refactor rabbitmq newcrashes method https://github.com/mozilla/socorro/commit/613a84f82814617a1c074f7e515cf68e5539ffce Merge pull request #1563 from rhelmer/bug924267-refactor-rabbitmq-newcrashes fixes bug 924267 - refactor rabbitmq newcrashes method
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 63
This feels [qa-] worthy to me; is it?
You need to log in before you can comment on or make changes to this bug.