[AccessFu] Utter the value of input widgets.

RESOLVED FIXED in mozilla27

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: yzen, Assigned: yzen)

Tracking

Trunk
mozilla27
ARM
Gonk (Firefox OS)
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
In cases such as <input type="range"> and its value changing, we need to utter the value changed.
.. and the current value when you land on it.
Created attachment 816041 [details] [diff] [review]
Output accessible values
Attachment #816041 - Flags: review?(yura.zenevich)
(Assignee)

Updated

5 years ago
Depends on: 915458
(Assignee)

Comment 3

5 years ago
Comment on attachment 816041 [details] [diff] [review]
Output accessible values

Review of attachment 816041 [details] [diff] [review]:
-----------------------------------------------------------------

While running all jsat test I got 1 failure:

63 ERROR TEST-UNEXPECTED-FAIL | chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/test_explicit_names.html | Context output is correct for textarea1 (output: text area, This is the text area text., Test Text Area) == (expected: text area, Test Text Area, This is the text area text.)

Since the value is now included before the name and the sub-tree is ignored the new output is actually correct.

Other than the above, looks good so r=me.

::: accessible/src/jsat/OutputGenerator.jsm
@@ +12,5 @@
>  const INCLUDE_DESC = 0x01;
>  const INCLUDE_NAME = 0x02;
> +const INCLUDE_VALUE = 0x04;
> +const INCLUDE_CUSTOM = 0x08;
> +const NAME_FROM_SUBTREE_RULE = 0x10;

Perhaps we should use 0x16 to make sure there's never overlap between NAME_FROM_SUBTREE_RULE and INCLUDE_CUSTOM or NAME_FROM_SUBTREE_RULE and INCLUDE_NAME.

::: accessible/tests/mochitest/jsat/output.js
@@ +24,5 @@
>    var context = new PivotContext(accessible, oldAccessible);
>    var output = aGenerator.genForContext(context).output;
>  
>    isDeeply(output, expected,
> +    "Context output is correct for " + aAccOrElmOrID + " (output: " + output.join(', ') + ') == (expected: ' + expected.join(', ') + ')');

NIT: line too long, mixed single and double quotes.
Attachment #816041 - Flags: review?(yura.zenevich) → review+
(In reply to Yura Zenevich [:yzen] from comment #3)
> Comment on attachment 816041 [details] [diff] [review]
> Output accessible values
> 
> Review of attachment 816041 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> While running all jsat test I got 1 failure:
> 
> 63 ERROR TEST-UNEXPECTED-FAIL |
> chrome://mochitests/content/a11y/accessible/tests/mochitest/jsat/
> test_explicit_names.html | Context output is correct for textarea1 (output:
> text area, This is the text area text., Test Text Area) == (expected: text
> area, Test Text Area, This is the text area text.)
> 
> Since the value is now included before the name and the sub-tree is ignored
> the new output is actually correct.
> 

Oops, fixed.

> Other than the above, looks good so r=me.
> 
> ::: accessible/src/jsat/OutputGenerator.jsm
> @@ +12,5 @@
> >  const INCLUDE_DESC = 0x01;
> >  const INCLUDE_NAME = 0x02;
> > +const INCLUDE_VALUE = 0x04;
> > +const INCLUDE_CUSTOM = 0x08;
> > +const NAME_FROM_SUBTREE_RULE = 0x10;
> 
> Perhaps we should use 0x16 to make sure there's never overlap between
> NAME_FROM_SUBTREE_RULE and INCLUDE_CUSTOM or NAME_FROM_SUBTREE_RULE and
> INCLUDE_NAME.
> 

I think you are thinking in decimal :)

> ::: accessible/tests/mochitest/jsat/output.js
> @@ +24,5 @@
> >    var context = new PivotContext(accessible, oldAccessible);
> >    var output = aGenerator.genForContext(context).output;
> >  
> >    isDeeply(output, expected,
> > +    "Context output is correct for " + aAccOrElmOrID + " (output: " + output.join(', ') + ') == (expected: ' + expected.join(', ') + ')');
> 
> NIT: line too long, mixed single and double quotes.

Fixed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0e82e8f1c85f

Landed. Yura, if you are doing any work on value changed events, lets keep it in this bug.
Whiteboard: [leave open]
(Assignee)

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Whiteboard: [leave open]
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.