924334 - [Music] Shuffle toggle button and 'shuffle play' button should be visually distinct

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Music, defect, P1)

Description

[sync-1]

Firefox os  v1.1
 Mozilla build ID:20130916041201
 
 Created an attachment (id=528244)
 pic
 
 DEFECT DESCRIPTION:
 User experience is not very well when turn off shuffle button
 
  REPRODUCING PROCEDURES:
 1、launch music player->go to Artists view and choose an artist whose has several songs(eg pic1)
 2、Choose to play all songs->turn off shuffle button on playscreen (eg pic2)
 3、back to the previous screen,you will see the shuffle button stlii highlight(eg pic3)->KO
 
  EXPECTED BEHAVIOUR:
 the shuffle button should better turn grey
 
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPAC
 moderate
 
  REPRODUCING RATE:
 3/3
 
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: logcat

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: pic

Comment 5

[liangxin]

I try to resolve this issue by add code in handleEvent function on music.js file.
The code as follow:
 switch (target.id) {
          case 'title-back':
            if (pendingPick) {
              if (ModeManager.currentMode === MODE_PICKER) {
                pendingPick.postError('pick cancelled');
                return;
              }

              cleanupPick();
            }

            ModeManager.pop();
+       asyncStorage.getItem(SETTINGS_OPTION_KEY, function(settings) {
+              playerSettings = settings;
+              var shuffleOption = (playerSettings && playerSettings.shuffle) ?
+                playerSettings.shuffle : false;            
+              SubListView.shuffleButton.disabled = !shuffleOption;  
+            });

           break;

Comment 6

[sync-1]

Created an attachment (id=535528)
 It can resolve this issue
 
 It can resolve this issue.

Comment 7

[sync-1]

Attachment: It can resolve this issue

Comment 8

[Jim Porter (:squib)]

I think this comes from a misunderstanding of what the shuffle button means in the album/artist view. It's not a toggle button like in the player; it's a button that means "start playing this playlist in shuffled mode", so there'd never be a time where it makes sense to gray this out. Jacqueline: do you have any ideas here?

Comment 9

[katieC]

(In reply to Jim Porter (:squib) from comment #8)
> I think this comes from a misunderstanding of what the shuffle button means
> in the album/artist view. It's not a toggle button like in the player; it's
> a button that means "start playing this playlist in shuffled mode", so
> there'd never be a time where it makes sense to gray this out. Jacqueline:
> do you have any ideas here?

[Filling in for JS this week, as she's on PTO.] 

Yes, to Jim's comment 8. In this case, the shuffle button is not a toggle.

In the Album view, there are 2 buttons - both are "PLAY" options. The traditional triangle PLAY button, plays the album in it's original song order. The second option is the SHUFFLE PLAY button, which plays the album in a random shuffle. 

The user can turn off shuffle option (as a toggle) once the Album has begun to play (as in the original attached JPG). If user returns to Album view (taps '<' back button), both options: 1) Play in order and 2) Shuffle Play are (visibly) available to the user.

[ This may be revisited in 2.2 ]

Comment 10

[Chris Lord [:cwiiis]]

Retitling to reflect what I assume this bug is now tracking.

Comment 11

[Jim Porter (:squib)]

We eliminated the "shuffle play" button in NGA. Resolving.