924340 - adblock plus add-on update is broken

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0 (Beta/Release)
Build ID: 20131007030203

Steps to reproduce:

1. Install older version of Adblock Plus from https://downloads.adblockplus.org/devbuilds/adblockplus/
2. Go to "Add-ons Manager" and check for updates to update Adblock Plus add-on to latest version


Actual results:

Add-on is updated but it didn't work, oddly add-ons manager shows that this add-on is enabled.
Disabling and enabling this add-on in Add-ons Manager is in some way workaround to not restet browser and get the add-on enabled after update.


Expected results:

Restartless add-on should be updated and should be also working after update.

Comment 1

[Alice0775 White]

Error in Error console:

Warning: WARN addons.xpi: Exception running bootstrap method startup on {d10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d}: [Exception... "Component returned failure code: 0xc1f30100 (NS_ERROR_FACTORY_EXISTS) [nsIComponentRegistrar.registerFactory]"  nsresult: "0xc1f30100 (NS_ERROR_FACTORY_EXISTS)"  location: "JS frame :: resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/***/AppData/Roaming/Mozilla/Firefox/Profiles/fos6s3nl.27/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///C:/Users/***/AppData/Roaming/Mozilla/Firefox/Profiles/fos6s3nl.27/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/contentPolicy.js :: PolicyImplementation.init :: line 368"  data: no]
Source File: resource://gre/modules/XPIProvider.jsm -> jar:file:///C:/Users/***/AppData/Roaming/Mozilla/Firefox/Profiles/fos6s3nl.27/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/bootstrap.js -> jar:file:///C:/Users/***/AppData/Roaming/Mozilla/Firefox/Profiles/fos6s3nl.27/extensions/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/contentPolicy.js
Line: 368


Regrssion window(m-c)
Good:
http://hg.mozilla.org/mozilla-central/rev/fd59f2cfbbff
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130810032339
Bad:
http://hg.mozilla.org/mozilla-central/rev/3d20597e0a07
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130811002840
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fd59f2cfbbff&tochange=3d20597e0a07

Regrssion window(fx-team)
Good:
http://hg.mozilla.org/integration/fx-team/rev/a0114f95b034
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130810054540
Bad:
http://hg.mozilla.org/integration/fx-team/rev/61e0fb09a73c
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0 ID:20130810164741
Pushlog:
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=a0114f95b034&tochange=61e0fb09a73c

Regressed by: Bug 853388

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

From the error, it sounds like this only affects restartless addons that implement content policies?

Comment 3

[:Irving Reid (No longer working on Firefox)]

Interesting that the update doesn't work, but disabling and re-enabling the add-on fixes it. I'll try to reproduce in my test environment.

Comment 4

[Dave Townsend [:mossop]]

Related to bug 905357 perhaps?

Comment 5

[:Irving Reid (No longer working on Firefox)]

Yes, it appears that the changes in async timing for some XPI Provider operations has changed sync/async behaviour enough that the AdBlock Plus workaround for bug 753687 is failing. I have a bit more investigation to do before I'm certain, but that's my working theory right now.

Comment 6

[Wladimir Palant]

(In reply to :Irving Reid from comment #5)
> Yes, it appears that the changes in async timing for some XPI Provider
> operations has changed sync/async behaviour enough that the AdBlock Plus
> workaround for bug 753687 is failing.

Yes, I can confirm that. XPI Provider is now uninstalling the old version and installing the new one synchronously, executing asynchronous actions in between isn't possible. As a work-around for bug 753687 Adblock Plus only removes the category entries synchronously on uninstall, the factory has to be unregistered asynchronously. However, this now means that the factory is still there when the new version tries to register it on install which is what causes the failure.

Comment 7

[Wladimir Palant]

Worked around this issue: https://hg.adblockplus.org/adblockplus/rev/f301c59925f9

Comment 8

[:Gavin Sharp [email: [e-mail]]]

"exposed by" bug 853388 is worth tracking with the dependency tree.

Comment 9

[:Irving Reid (No longer working on Firefox)]

Oops, didn't mean to remove the dependency on bug 853388. At this point, I thing the right approach is to fix bug 753687 rather than leave clients of nsCategoryCache having to do async workarounds.

Comment 10

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Bug 771441 is the long-term fix for this type of issue.

Comment 11

[Wladimir Palant]

Note that Adblock Plus 2.4 (released on Wednesday) works around this issue. So this bug as filed can be resolved - actual work should happen in bug 753687 and bug 771441 anyway.

Comment 12

[:Irving Reid (No longer working on Firefox)]

Based on the ABP workaround and fix to bug 753687 I agree with resolving this.

Comment 13

[Lukas Blakk [:lsblakk] use ?needinfo]

Irving - should we be uplifting the fix in bug 753687 to mozilla-beta then to ensure this is also fixed on FF26?

Comment 14

[:Irving Reid (No longer working on Firefox)]

Sounds like a good idea to me. I'll fill in the a? form on bug 753687.

Comment 15

[:Irving Reid (No longer working on Firefox)]

based on the a- on bug 753687, do we still need tracking-26 on this bug?

Comment 16

[Lukas Blakk [:lsblakk] use ?needinfo]

Indeed we do not - thanks for calling it out.

Comment 17

[:Gavin Sharp [email: [e-mail]]]

Looks like we ended up not taking bug 753687... But I suppose from bug 753687 comment 15 that we don't need to track this.

Comment 18

[Manuela Muntean [Away]]

I'm not able to reproduce this issue on Win 8 64-bit, neither with the Nightly from 2013-08-10 nor the one from 2013-08-11.

The add-on is updated properly in the Add-ons Manager (to the latest version: 2.4.1.3756) and it also seems to be working: I tried to block an image from cnn.com and it worked.

Also, I'm not seeing in the console the error mentioned in comment 1.

Any thoughts/suggestions?

Comment 19

[Wladimir Palant]

(In reply to Manuela Muntean [:Manuela] [QA] from comment #18)
> I'm not able to reproduce this issue on Win 8 64-bit, neither with the
> Nightly from 2013-08-10 nor the one from 2013-08-11.
> 
> The add-on is updated properly in the Add-ons Manager (to the latest
> version: 2.4.1.3756) and it also seems to be working: I tried to block an
> image from cnn.com and it worked.

See comment 7 and comment 11 - current Adblock Plus versions are no longer affected.

Comment 20

[Manuela Muntean [Away]]

Verified as fixed based on comment 19.