924461 - customize search engines should allow the user to specify the order of engines

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect, P5)

Comment 1

[:Margaret Leibovic]

This will need some UX direction.

Comment 2

[Ian Barlow (:ibarlow)]

This isn't final art by any means, but one simple pattern we could apply is to add a 'grippy' graphic to the right of the list items, to show that items can be dragged up and down the list. 

http://cl.ly/image/113g1F410P1u

The one thing to consider here would be how to handle the default search provider at the top of the list. A couple of ways to handle it could be

1. Items that are dragged above it become the default automatically
or 
2. Items cannot be dragged above the default provider

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

In the interest of giving users as much control as possible, I prefer option 1.

Comment 4

[Ian Barlow (:ibarlow)]

Works for me

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

filter on [mass-p5]

Comment 6

[:Margaret Leibovic]

As a first step, we should just add the same "Change order" context menu item that we use for the home panel settings.

As we've seen in bug 974983, making preference items draggable is hard.

Comment 7

[Francisco Jordano [:arcturus] [:francisco]]

Would like to work on this with some help from the mentor :)

Comment 8

[:Margaret Leibovic]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #7)
> Would like to work on this with some help from the mentor :)

Hi Francisco! Chenxia is on vacation, so I can help you out.

You should start by taking a look at the code we use to create the "Change order" context menu for the home panel settings. Here's where you can find some of that logic:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/preferences/PanelsPreference.java?force=1#167

You'll then want to add similar logic to the search preferences, likely somewhere in here:

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/preferences/SearchEnginePreference.java?force=1#115

In order to actually change the order of the search engine, you'll need to send a message to JS, since we use the toolkit search engine manager, which is written in JS. You can follow a patten similar to what we use to change the default search engine:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/preferences/SearchPreferenceCategory.java#60
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#7054

Let me know if you have any questions!

Comment 9

[Francisco Jordano [:arcturus] [:francisco]]

Great, this weekend I'll take a look to this following the instructions!

Comment 10

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to :Margaret Leibovic from comment #8)
> 
> You'll then want to add similar logic to the search preferences, likely
> somewhere in here:
> 
> http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/
> preferences/SearchEnginePreference.java?force=1#115
> 

Hei Margaret after taking a look to the code, you think is better to kind of repeat the logic from PanelsPreferences into SearchEnginePreference, or do you think that makes sense to try to generalise into CustomListPreference, making it be 'reorderable'?

What are your thoughts?

Comment 11

[:Margaret Leibovic]

(In reply to Francisco Jordano [:arcturus] [:francisco] from comment #10)
> (In reply to :Margaret Leibovic from comment #8)
> > 
> > You'll then want to add similar logic to the search preferences, likely
> > somewhere in here:
> > 
> > http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/
> > preferences/SearchEnginePreference.java?force=1#115
> > 
> 
> Hei Margaret after taking a look to the code, you think is better to kind of
> repeat the logic from PanelsPreferences into SearchEnginePreference, or do
> you think that makes sense to try to generalise into CustomListPreference,
> making it be 'reorderable'?
> 
> What are your thoughts?

Sorry for the delayed response! I was the one on vacation last week :)

I think that generalizing the logic here makes sense, good catch.

Chenxia has also done a lot of work in this part of the code, so she's a good person to ask questions if you run into any issues. Feel free to post a WIP patch for feedback!

Comment 12

[Kevin Brosnan [Ex-Mozilla]]

Renominate, bug 1073775 comment 15 though 19

Comment 13

[:Margaret Leibovic]

This doesn't need to track a specific release, so it's a +, but it would be really nice to have.

Comment 15

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 16

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.