Closed Bug 924532 Opened 6 years ago Closed 6 years ago

Keyboard focused help button in Identity panel has double outlines

Categories

(Firefox :: Theme, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 28

People

(Reporter: mconley, Assigned: aks)

References

Details

(Keywords: polish, Whiteboard: [good first bug][mentor=mconley][lang=css])

Attachments

(1 file)

Bug 428943 adds a new button to the identity panel that lets users access a SUMO article regarding secure connections.

When that button is keyboard focused on Windows, there are two dotted outlines around the button. There should only be a single dotted outline.

See: http://i.imgur.com/n4vDNzK.png
I would like to work on this bug.
(In reply to Akshat Kedia from comment #1)
> I would like to work on this bug.

Great! Do you have a build of Firefox on Windows ready? If not, please follow these instructions:

https://developer.mozilla.org/en/docs/Simple_Firefox_build

(Make sure you complete the Windows build prerequisites first)

Once you have that, I can guide you the rest of the way, and I'll assign the bug to you.
If you need any help getting your build environment set up, you can always ask in #introduction on irc.mozilla.org (https://wiki.mozilla.org/IRC)
Done with cloning mozilla central. :) Now whats next ?
(In reply to Akshat Kedia from comment #4)
> Done with cloning mozilla central. :) Now whats next ?

Now that you've cloned the repo, you have to build Firefox. This might take a little time, since it's memory and processor intensive. When it's done though, you'll have a Firefox executable that you can play around with and modify!

Please read this documentation: https://developer.mozilla.org/en/docs/Simple_Firefox_build on how to get that going - and ensure that you complete the Windows build prerequisites first.

If you get stuck getting your build up, join #introduction on irc.mozilla.org (https://wiki.mozilla.org/IRC) and the fine folks in there can get you going.
Actually this is not my first bug :P I actually meant how do I get started with fixing this bug ?
Take a look at /browser/themes/windows/browser.css, play around with this rule

  #identity-popup-help-icon:-moz-focusring

My guess is that the inner element of the button already have the outline style, and that rule introduce the second dotted outline
Is mozapps/skin/places/defaultFavicon.png (tab icon image) causing the issue ?
(In reply to Soumya Kanti Chakraborty from comment #8)
> Is mozapps/skin/places/defaultFavicon.png (tab icon image) causing the issue
> ?

No.

(In reply to lie.r.min.g from comment #7)
> Take a look at /browser/themes/windows/browser.css, play around with this
> rule
> 
>   #identity-popup-help-icon:-moz-focusring
> 
> My guess is that the inner element of the button already have the outline
> style, and that rule introduce the second dotted outline

That's correct. This rule should just be removed.
Component: Location Bar → Theme
(In reply to Akshat Kedia from comment #6)
> Actually this is not my first bug :P I actually meant how do I get started
> with fixing this bug ?

Are you working on this bug, else I can take it upon.
Yeap sorry for the delay but was a bit busy with college, I am still working on this bug.
I would like to work on this bug, can you assign it to me.
Hey taj,

I think Akshat got to this one first - I've just been slow to assign it (which I'll do now). Sorry!

Akshat - please needinfo me (using the "Need more information from" checkbox and text input below) if you have any questions on this bug. Thanks!

-Mike
Assignee: nobody → aksht.kedia
Attached patch 924532.patchSplinter Review
I am really sorry for the delay. I am not using a windows machine so could not check whether this patch fixes the bug or not. Please check and let me know.
Attachment #825408 - Flags: review?(mconley)
Attachment #825408 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/e95abbea3283
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
I have verified that this is fixed in Firefox 28.0a1 2013-11-08 on x86_64 Windows 7.
Thanks for the help Ganesh.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.