Closed
Bug 924568
Opened 8 years ago
Closed 8 years ago
Validate hosted app URL before adding
Categories
(DevTools Graveyard :: WebIDE, defect, P1)
DevTools Graveyard
WebIDE
Tracking
(firefox26 verified, firefox27 verified, b2g-v1.2 fixed)
VERIFIED
FIXED
Firefox 27
People
(Reporter: jryans, Assigned: paul)
Details
Attachments
(1 file, 1 obsolete file)
4.93 KB,
patch
|
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Currently you can "add" a hosted app without entering a URL. You then end up with a broken app that cannot select or remove in the project list.
Assignee | ||
Updated•8 years ago
|
Priority: -- → P1
Reporter | ||
Comment 1•8 years ago
|
||
Actually, it's even worse, as it seems to make the entire list of projects unusable once you close and re-open the App Manager after doing this.
Assignee | ||
Comment 2•8 years ago
|
||
There might be 2 bugs here: 1) template or store issue (invalid data should not break the UI) 2) the (+) button should act the same way as the form (with validation)
Assignee: nobody → paul
Assignee | ||
Comment 3•8 years ago
|
||
Attachment #814810 -
Flags: review?(poirot.alex)
Assignee | ||
Updated•8 years ago
|
Whiteboard: [needed-in-aurora-26]
Assignee | ||
Updated•8 years ago
|
Whiteboard: [needed-in-aurora-26] → [needed-in-aurora-26][waiting-for-review]
Comment 4•8 years ago
|
||
Comment on attachment 814810 [details] [diff] [review] Patch V1 Review of attachment 814810 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! ::: browser/devtools/app-manager/app-projects.js @@ +62,5 @@ > let deferred = promise.defer(); > > + if (!project.location) { > + // We need to make sure this object has a `.location` property. > + deferred.reject("No location property"); I'd have been more explicit with the error message. Like "Missing location property on project object."
Attachment #814810 -
Flags: review?(poirot.alex) → review+
Assignee | ||
Comment 5•8 years ago
|
||
Assignee | ||
Updated•8 years ago
|
Keywords: checkin-needed
Assignee | ||
Updated•8 years ago
|
Whiteboard: [needed-in-aurora-26][waiting-for-review] → [needed-in-aurora-26][land-in-fx-team]
Updated•8 years ago
|
Attachment #814810 -
Attachment is obsolete: true
Comment 6•8 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/bfd211789733
Keywords: checkin-needed
Whiteboard: [needed-in-aurora-26][land-in-fx-team] → [needed-in-aurora-26][fixed-in-fx-team]
Comment 7•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/bfd211789733
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [needed-in-aurora-26][fixed-in-fx-team] → [needed-in-aurora-26]
Target Milestone: --- → Firefox 27
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 814843 [details] [diff] [review] Patch to land [Approval Request Comment] Bug caused by (feature/regressing bug #): new feature (app manager) User impact if declined: Can break his project list Testing completed (on m-c, etc.): fx-team Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #814843 -
Flags: approval-mozilla-aurora?
Assignee | ||
Updated•8 years ago
|
Whiteboard: [needed-in-aurora-26] → [waiting-for-aurora-approval]
Updated•8 years ago
|
Attachment #814843 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•8 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/24502fc769cd
status-b2g-v1.2:
--- → fixed
status-firefox26:
--- → fixed
status-firefox27:
--- → fixed
Whiteboard: [waiting-for-aurora-approval]
Comment 10•7 years ago
|
||
Verified as fixed on latest Aurora 27.0a2 (20131112004004) and Firefox 26 beta 4 (20131111154639) using Win 7 64-bit, Ubuntu 13.04 32-bit and Mac OS X 10.6.8.
Updated•3 years ago
|
Product: Firefox → DevTools
Updated•1 year ago
|
Product: DevTools → DevTools Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•