924568 - Validate hosted app URL before adding

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Currently you can "add" a hosted app without entering a URL.  You then end up with a broken app that cannot select or remove in the project list.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Actually, it's even worse, as it seems to make the entire list of projects unusable once you close and re-open the App Manager after doing this.

Comment 2

[Paul Rouget [:paul]]

There might be 2 bugs here:
1) template or store issue (invalid data should not break the UI)
2) the (+) button should act the same way as the form (with validation)

Comment 3

[Paul Rouget [:paul]]

Attachment: Patch V1

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 814810 [details] [diff] [review]
Patch V1

Review of attachment 814810 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

::: browser/devtools/app-manager/app-projects.js
@@ +62,5 @@
>      let deferred = promise.defer();
>  
> +    if (!project.location) {
> +      // We need to make sure this object has a `.location` property.
> +      deferred.reject("No location property");

I'd have been more explicit with the error message.
Like "Missing location property on project object."

Comment 5

[Paul Rouget [:paul]]

Attachment: Patch to land

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/bfd211789733

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bfd211789733

Comment 8

[Paul Rouget [:paul]]

Comment on attachment 814843 [details] [diff] [review]
Patch to land

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (app manager)
User impact if declined: Can break his project list
Testing completed (on m-c, etc.): fx-team
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/24502fc769cd

Comment 10

[Petruta Horea [:phorea], Desktop Test Engineering]

Verified as fixed on latest Aurora 27.0a2 (20131112004004) and Firefox 26 beta 4 (20131111154639) using Win 7 64-bit, Ubuntu 13.04 32-bit and Mac OS X 10.6.8.