924592 - [Contacts][Enhancement] Use Set in the logic for the list select mode

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Francisco Jordano [:arcturus] [:francisco]]

Right now we are using an object to keep track of the users selected, as @rwaldon suggested, we could simplify the code using Set.

Comment 1

[Rick Waldron [:rwaldron]]

This was the idea I had: https://github.com/mozilla-b2g/gaia/pull/12591#issuecomment-25843710

Comment 2

[Jose Manuel Cantera]

I'm sympathetic with the idea but using ES6 objects can be a nightmare specially when porting the apps to other Web OSs. I've suffered it with the Clock App which abuses from that.

Comment 3

[Rick Waldron [:rwaldron]]

(In reply to Jose M. Cantera from comment #2)
> I'm sympathetic with the idea but using ES6 objects can be a nightmare
> specially when porting the apps to other Web OSs. I've suffered it with the
> Clock App which abuses from that.

We have a directive from Mozilla leadership to use new language features as they stabilize and are implemented in Firefox. This page: https://developer.mozilla.org/en-US/docs/Web/JavaScript/ECMAScript_6_support_in_Mozilla was marked with the consensus level specifically at the request of FirefoxOS leadership to indicate which features were safe to use in FirefoxOS (align Firefox version + Green blocks = safe to use).

Comment 4

[Johan Lorenzo [:jlorenzo]]

Do you still want to refactor that part, Francisco?

Comment 5

[Francisco Jordano [:arcturus] [:francisco]]

Closing as this was merged (the idea from :rwaldron) 1 year ago.