Closed
Bug 924614
Opened 11 years ago
Closed 11 years ago
Scratchpad shows up in developer tools menu twice
Categories
(DevTools :: Framework, defect)
DevTools
Framework
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: bbenvie, Assigned: bbenvie)
Details
Attachments
(1 file, 1 obsolete file)
|
8.07 KB,
patch
|
bbenvie
:
review+
|
Details | Diff | Splinter Review |
With bug 895180 landing, a new menu was added for the Scratchpad tab. It seems a menu item is added for each default tool. The problem is that each of the default tools isn't guaranteed to support a local target, such as the Scratchpad panel. As such, we have a menu item that doesn't do anything.
|
Assignee | |
Updated•11 years ago
|
Summary: remote scratchpad → Scratchpad shows up in developer tools menu twice
|
|
Assignee | |
Comment 1•11 years ago
|
||
Adds a new "inMenu" boolean field to tool definitions which is used to determine whether to add a tool to the Web Developer menu. This replaces the previous special casing of the "options" tool with a more general solution.
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•11 years ago
|
Component: Developer Tools: Scratchpad → Developer Tools: Framework
|
|
Assignee | |
Updated•11 years ago
|
Attachment #814558 -
Flags: review?(mratcliffe)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 814558 [details] [diff] [review] bug-924614.patch Review of attachment 814558 [details] [diff] [review]: ----------------------------------------------------------------- Looks good but please update https://developer.mozilla.org/docs/Tools/DevToolsAPI to include this new property.
Attachment #814558 -
Flags: review?(mratcliffe) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Missed checking for `inMenu` in `_addToolToWindows`. This patch fixes that. A try-run before I push this: https://tbpl.mozilla.org/?tree=Try&rev=740d037adbba
Attachment #814558 -
Attachment is obsolete: true
Attachment #815013 -
Flags: review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7bae66ad4253
Whiteboard: [fixed-in-fx-team]
|
|
Assignee | |
Comment 5•11 years ago
|
||
Updated https://developer.mozilla.org/en-US/docs/Tools/DevToolsAPI.
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7bae66ad4253
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•