Closed Bug 924614 Opened 8 years ago Closed 8 years ago

Scratchpad shows up in developer tools menu twice

Categories

(DevTools :: Framework, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 27

People

(Reporter: bbenvie, Assigned: bbenvie)

Details

Attachments

(1 file, 1 obsolete file)

With bug 895180 landing, a new menu was added for the Scratchpad tab. It seems a menu item is added for each default tool. The problem is that each of the default tools isn't guaranteed to support a local target, such as the Scratchpad panel. As such, we have a menu item that doesn't do anything.
Summary: remote scratchpad → Scratchpad shows up in developer tools menu twice
Attached patch bug-924614.patch (obsolete) — Splinter Review
Adds a new "inMenu" boolean field to tool definitions which is used to determine whether to add a tool to the Web Developer menu. This replaces the previous special casing of the "options" tool with a more general solution.
Assignee: nobody → bbenvie
Status: NEW → ASSIGNED
Component: Developer Tools: Scratchpad → Developer Tools: Framework
Attachment #814558 - Flags: review?(mratcliffe)
Comment on attachment 814558 [details] [diff] [review]
bug-924614.patch

Review of attachment 814558 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but please update https://developer.mozilla.org/docs/Tools/DevToolsAPI to include this new property.
Attachment #814558 - Flags: review?(mratcliffe) → review+
Attached patch bug-924614.patchSplinter Review
Missed checking for `inMenu` in `_addToolToWindows`. This patch fixes that. A try-run before I push this: https://tbpl.mozilla.org/?tree=Try&rev=740d037adbba
Attachment #814558 - Attachment is obsolete: true
Attachment #815013 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/7bae66ad4253
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.