924649 - Add extraName() to more LInstruction subclasses

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Dan Gohman [:sunfish]]

Attachment: lir-extranames.patch

When reading debugging output, it's often handy to know what kind of LShiftI something is, what type is being Boxed, or what math function is being called.

Comment 1

[Dan Gohman [:sunfish]]

Attachment: math-function-names.patch

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 814587 [details] [diff] [review]
lir-extranames.patch

Review of attachment 814587 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/CodeGenerator.cpp
@@ +2767,5 @@
>          perfSpewer->startBasicBlock(current->mir(), masm);
>  #endif
>  
>          for (; iter != current->end(); iter++) {
> +            if (const char *extra = iter->extraName())

Nit: can you wrap this "if" in an #ifdef DEBUG?

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 814588 [details] [diff] [review]
math-function-names.patch

Review of attachment 814588 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/MIR.h
@@ +3671,5 @@
>      }
> +
> +    void printOpcode(FILE *fp) const;
> +
> +    static const char *functionName(Function function);

Nit: static method so FunctionName

Comment 4

[Dan Gohman [:sunfish]]

(In reply to Jan de Mooij [:jandem] from comment #2)
> @@ +2767,5 @@
> >          perfSpewer->startBasicBlock(current->mir(), masm);
> >  #endif
> >  
> >          for (; iter != current->end(); iter++) {
> > +            if (const char *extra = iter->extraName())
> 
> Nit: can you wrap this "if" in an #ifdef DEBUG?

Done.

(In reply to Jan de Mooij [:jandem] from comment #3)
> @@ +3671,5 @@
> >      }
> > +
> > +    void printOpcode(FILE *fp) const;
> > +
> > +    static const char *functionName(Function function);
> 
> Nit: static method so FunctionName

Done.

https://hg.mozilla.org/integration/mozilla-inbound/rev/06a14dd30924
https://hg.mozilla.org/integration/mozilla-inbound/rev/66369a6578f7

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/06a14dd30924
https://hg.mozilla.org/mozilla-central/rev/66369a6578f7