Closed
Bug 924738
Opened 11 years ago
Closed 11 years ago
Move third party sources outside of base
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: bnicholson, Assigned: bnicholson)
References
(Blocks 1 open bug)
Details
Attachments
(3 files, 2 obsolete files)
182.36 KB,
patch
|
Details | Diff | Splinter Review | |
250.94 KB,
patch
|
rnewman
:
review+
gps
:
review+
|
Details | Diff | Splinter Review |
52.84 KB,
patch
|
rnewman
:
review+
|
Details | Diff | Splinter Review |
Having all third party source directly under base (which is generally o.m.g.) is not IDE-friendly, so we should move them outside. This overlaps with bug 890586, but is less ambitious. Here are the shell commands for all file moves, as requested by rnewman: git mv httpclientandroidlib/ ../thirdparty/ git mv json-simple/ ../thirdparty/ git mv apache/ ../thirdparty/ git mv braille/ ../thirdparty/ git mv websockets/ ../thirdparty/ Thanks in advance for nalexander or rnewman for syncing these changes with the services branch :)
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #814711 -
Flags: review?(rnewman)
Assignee | ||
Comment 3•11 years ago
|
||
I was going to keep this bug as simple as possible, but we want this change too if we really want to make IDE integration painless. cd thirdparty/ git mv braille/com/ . rm -r braille/ mkdir -p org/mozilla git mv apache/ org/mozilla/ mkdir -p ch/boye git mv httpclientandroidlib/ ch/boye/ mkdir -p com/codebutler git mv websockets/ com/codebutler/android_websockets mkdir org/json git mv json-simple/ org/json/simple
Attachment #814713 -
Flags: review?(rnewman)
Comment 4•11 years ago
|
||
In principle, I support this. And, to my mind, in for a penny, in for a pound: we should follow Java's directory structure everywhere. I have a few nits with the build system integration, and I'd kind of prefer to land Bug 923306 before doing this rename the world operation, but f+ from me.
Comment 5•11 years ago
|
||
Let's wait for the build bug to land before we do this, 'cos I think this is easier to reconstitute. Work for you, Brian?
Depends on: 923306
Assignee | ||
Comment 6•11 years ago
|
||
WFM
Assignee | ||
Comment 7•11 years ago
|
||
Rebased
Attachment #814711 -
Attachment is obsolete: true
Attachment #814711 -
Flags: review?(rnewman)
Attachment #817379 -
Flags: review?(rnewman)
Assignee | ||
Comment 8•11 years ago
|
||
Rebased
Attachment #814713 -
Attachment is obsolete: true
Attachment #814713 -
Flags: review?(rnewman)
Attachment #817380 -
Flags: review?(rnewman)
Comment 9•11 years ago
|
||
Comment on attachment 817380 [details] [diff] [review] 0002-Bug-924738-Use-package-hierarchy-for-third-party-lib.patch, v2 These look fine to me, but needs build peer review.
Attachment #817380 -
Flags: review?(rnewman)
Attachment #817380 -
Flags: review?(gps)
Attachment #817380 -
Flags: review+
Comment 10•11 years ago
|
||
Comment on attachment 817379 [details] [diff] [review] 0001-Bug-924738-Move-third-party-sources-outside-of-base.patch, v2 Fold these together?
Attachment #817379 -
Flags: review?(rnewman)
Comment 11•11 years ago
|
||
This updates java-third-party-sources.mn, which isn't currently used in the build.
Attachment #817555 -
Flags: review+
Comment 12•11 years ago
|
||
Upstream copy script change: https://github.com/mozilla-services/android-sync/pull/365 Verified that with the three hg parts applied, this is a no-op when run.
Comment 13•11 years ago
|
||
Comment on attachment 817380 [details] [diff] [review] 0002-Bug-924738-Use-package-hierarchy-for-third-party-lib.patch, v2 Review of attachment 817380 [details] [diff] [review]: ----------------------------------------------------------------- IMO this counts as trivial and didn't require build peer review.
Attachment #817380 -
Flags: review?(gps) → review+
Assignee | ||
Comment 14•11 years ago
|
||
Nick wants to wait for bug 925185 before we land this one.
Depends on: 925185
Comment 16•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/070ebdc4a8e4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•