Closed Bug 924757 Opened 6 years ago Closed 6 years ago

PJS: Remove tagged callee tokens

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla27

People

(Reporter: shu, Assigned: shu)

Details

Attachments

(1 file)

Remove PJS-tagged callee tokens. (r=?)
37.11 KB, patch
jandem
: review+
Details | Diff | Splinter Review 
Tagging callee tokens is unnecessary as the execution mode is fixed per activation.
Attachment #814724 - Flags: review?(jdemooij)
Assignee: nobody → shu
Status: NEW → ASSIGNED
This will incidentally make things cleaner for bug 923724, which won't have this weird ParallelFunction tagged callee token to deal with.
Comment on attachment 814724 [details] [diff] [review]
Remove PJS-tagged callee tokens. (r=?)

Review of attachment 814724 [details] [diff] [review]:
-----------------------------------------------------------------

Really nice!

::: js/src/jit/IonFrameIterator.h
@@ +104,1 @@
>      IonFrameIterator(const ActivationIterator &activations);

Pre-existing nit: can you make these constructors explicit?
Attachment #814724 - Flags: review?(jdemooij) → review+
https://hg.mozilla.org/mozilla-central/rev/76832c8a9c37
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.