Closed
Bug 924757
Opened 12 years ago
Closed 12 years ago
PJS: Remove tagged callee tokens
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla27
People
(Reporter: shu, Assigned: shu)
Details
Attachments
(1 file)
|
37.11 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Tagging callee tokens is unnecessary as the execution mode is fixed per activation.
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #814724 -
Flags: review?(jdemooij)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → shu
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•12 years ago
|
||
This will incidentally make things cleaner for bug 923724, which won't have this weird ParallelFunction tagged callee token to deal with.
|
||
Comment 3•12 years ago
|
||
Comment on attachment 814724 [details] [diff] [review]
Remove PJS-tagged callee tokens. (r=?)
Review of attachment 814724 [details] [diff] [review]:
-----------------------------------------------------------------
Really nice!
::: js/src/jit/IonFrameIterator.h
@@ +104,1 @@
> IonFrameIterator(const ActivationIterator &activations);
Pre-existing nit: can you make these constructors explicit?
Attachment #814724 -
Flags: review?(jdemooij) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in
before you can comment on or make changes to this bug.
Description
•