Open Bug 92478 Opened 18 years ago Updated 10 years ago

Rewrite nsXBLService::FetchBindingDocument so that it avoid copy

Categories

(Core :: XBL, defect)

x86
Windows 2000
defect
Not set

Tracking

()

Future

People

(Reporter: dougt, Unassigned)

References

Details

(Keywords: perf)

Attachments

(1 file)

nsXBLService::FetchBindingDocument could use nsIInputStream::ReadSegments to
avoid copying.  Currently it calls Read() which copies bytes into a local buffer.
Blocks: 7251
Keywords: perf
Darin, can you review this?
Keywords: patch
Target Milestone: --- → mozilla0.9.4
reassigning to default owner.
Assignee: dougt → hyatt
The synchronous case in this function is almost never hit, so shouldn't make
much of a difference.

If you want to check it in, sr=hyatt.

Assignee: hyatt → dougt
Target Milestone: mozilla0.9.4 → Future
r/sr=darin
No longer blocks: 7251
Blocks: 7251
to default.
Assignee: dougt → hyatt
At this point we load the data using nsSyncLoadService::LoadLocalXBLDocument,
which wraps the raw stream in a buffered input stream and passes that to the
OnDataAvailable (the parser).  I assume that this in fact does do an extra copy,
right?
QA Contact: jrgmorrison → xbl
Assignee: hyatt → nobody
You need to log in before you can comment on or make changes to this bug.