924833 - Re-enable test_receive_call.py

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Zac C (:zac)]

Re enable this test

Comment 1

[Viorela Ioia [:viorela]]

I will try this one

Comment 2

[Bob Silverberg [:bsilverberg]]

Thank you for your enthusiasm, Viorela, but I think this task is being blocked by bug 924831 and 924835, so it's not quite ready to be worked on.

Comment 3

[Bob Silverberg [:bsilverberg]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17593

Comment 4

[Viorela Ioia [:viorela]]

Comment on attachment 8396551 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17593

The test failed once

Comment 5

[Robert Chira [:RobertC]]

Test started failing after running multiple times. See comment in PR.

Comment 6

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8396551 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17593

This is ready to be re-reviewed.

Comment 7

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8396551 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17593

If you have time, davehunt, a review of this would be appreciated.

Comment 8

[Florin Strugariu [:Bebe]]

Comment on attachment 8396551 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17593

Tested this and looks OK

Comment 9

[Bob Silverberg [:bsilverberg]]

This test is doing well as an adhoc on CI, but still needs a review from Zac and/or Dave to be ready to merge.

Comment 10

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8396551 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17593

Thanks Bob, sorry for the delay. I'm going to r- for the comments mentioned in the pull request. If there's an urgent need to get this landed then I don't see any real blockers, but if we have time then I'd suggest taking a little longer on this.

Comment 11

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8396551 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17593

I added a few comments that I think would be good to fix up, so r+ with these changes. Note that I haven't run the tests myself though, and I did notice that Travis failed.

Comment 12

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 8396551 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17593

Looks great, thanks Bob! :-)

Comment 13

[Zac C (:zac)]

Comment on attachment 8396551 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17593

r+!!

Comment 14

[Zac C (:zac)]

Merged, yay!

It's a great test:
https://github.com/mozilla-b2g/gaia/commit/29e9731148ef3960485d2e4e232de5ef09cd4832

Comment 15

[Ed Morley [:emorley]]

Reverted for:
https://tbpl.mozilla.org/php/getParsedLog.php?id=38255056&tree=B2g-Inbound
{
09:09:49     INFO - Installing gaia-ui-tests into virtualenv /builds/slave/test/build/venv
09:09:49     INFO - Running command: ['/builds/slave/test/build/venv/bin/pip', 'install', '--download-cache', '/builds/slave/test/build/venv/cache', '-r', '/builds/slave/test/gaia/tests/python/gaia-ui-tests/tbpl_requirements.txt', '--no-index', '--find-links', 'http://pypi.pvt.build.mozilla.org/pub', '--find-links', 'http://pypi.pub.build.mozilla.org/pub', '-e', '/builds/slave/test/gaia/tests/python/gaia-ui-tests'] in /builds/slave/test/build
09:09:49     INFO - Copy/paste: /builds/slave/test/build/venv/bin/pip install --download-cache /builds/slave/test/build/venv/cache -r /builds/slave/test/gaia/tests/python/gaia-ui-tests/tbpl_requirements.txt --no-index --find-links http://pypi.pvt.build.mozilla.org/pub --find-links http://pypi.pub.build.mozilla.org/pub -e /builds/slave/test/gaia/tests/python/gaia-ui-tests
09:09:50     INFO -  Ignoring indexes: http://pypi.python.org/simple/
09:09:50     INFO -  Obtaining file:///builds/slave/test/gaia/tests/python/gaia-ui-tests
09:09:50     INFO -    Running setup.py egg_info for package from file:///builds/slave/test/gaia/tests/python/gaia-ui-tests
09:09:50     INFO -  Requirement already satisfied (use --upgrade to upgrade): marionette-client in ./venv/lib/python2.7/site-packages (from -r /builds/slave/test/gaia/tests/python/gaia-ui-tests/tbpl_requirements.txt (line 1))
09:09:50     INFO -  Requirement already satisfied (use --upgrade to upgrade): mozdevice>=0.31 in ./venv/lib/python2.7/site-packages (from gaiatest)
09:09:50     INFO -  Requirement already satisfied (use --upgrade to upgrade): moztest>=0.3 in ./venv/lib/python2.7/site-packages (from gaiatest)
09:09:50     INFO -  Downloading/unpacking plivo==0.9.6 (from gaiatest)
09:09:50     INFO -    Could not find any downloads that satisfy the requirement plivo==0.9.6 (from gaiatest)
09:09:50     INFO -  No distributions at all found for plivo==0.9.6 (from gaiatest)
09:09:50     INFO -  Storing complete log in /home/cltbld/.pip/pip.log
09:09:50    ERROR - Return code: 1
09:09:50    FATAL - Error running install of package, /builds/slave/test/build/venv/bin/pip install --download-cache /builds/slave/test/build/venv/cache -r /builds/slave/test/gaia/tests/python/gaia-ui-tests/tbpl_requirements.txt --no-index --find-links http://pypi.pvt.build.mozilla.org/pub --find-links http://pypi.pub.build.mozilla.org/pub -e /builds/slave/test/gaia/tests/python/gaia-ui-tests!
}

Please make sure the package is on the mirror before relanding, or else tweak the patch so TBPL jobs don't require it.

Revert commit:
https://github.com/mozilla-b2g/gaia/commit/381009095bc7d2b9aea26a641f5e8df7c8728efc

Comment 16

[Zac C (:zac)]

Re-landed, yay!

https://github.com/mozilla-b2g/gaia/commit/4b6c9d4929c57005ab142e8eb3dc6783d55c427c