Closed
Bug 924879
Opened 12 years ago
Closed 12 years ago
Minor cleanups for Parser.jsm
Categories
(DevTools :: Debugger, defect, P2)
DevTools
Debugger
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: vporof, Assigned: vporof)
References
Details
Attachments
(1 file)
|
54.66 KB,
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
This module has some dead code that's not exercised by tests, along with some other small cruft that has accumulated. The original intent for it was bug 852931, however it hasn't landed yet and doesn't look like it will in the very near future.
Since I've been changing things in bug 725235, I'm going to remove the unused code because I don't know if I'm breaking things or not.
|
Assignee | |
Updated•12 years ago
|
Attachment #814855 -
Flags: review?(past)
|
|
Assignee | |
Comment 1•12 years ago
|
||
I didn't break anything: https://tbpl.mozilla.org/?tree=Try&rev=881ab19824b5
|
|
Assignee | |
Updated•12 years ago
|
Priority: -- → P2
|
||
Comment 2•12 years ago
|
||
Comment on attachment 814855 [details] [diff] [review]
dbg-parser-cleanup.patch
Review of attachment 814855 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine.
Attachment #814855 -
Flags: review?(past) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Assignee: nobody → vporof
Whiteboard: [fixed-in-fx-team]
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 27
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•