924903 - [Contacts] Custom tag for mobile, email an address can be edited but it is not saved

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[isabelrios]

Checked with v1.2 latest build (10/09):
Gecko-bd1bd24
Gaia-1499c58

STR
1. Create a mew contact (or edit an existing one)
2. Tap on Mobile, to change the mobile type assigned
3. Tap on Custom field and write something
4. Tap on Done

EXPECTED
It is possible to add a custom tag for mobile, email or address information.

ACTUAL
Although it is possible to tap on Custom field and write a different tag, when tapping on Done, the change is dismissed.

Comment 1

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: 12769.html

Comment 2

[Jose Manuel Cantera]

Comment on attachment 815314 [details]
12769.html

good work German,

thanks!

Comment 3

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/a2932738a6c05382e0f17284a3d24542439c9afe

Comment 4

[James Lal [:lightsofapollo]]

backed out https://github.com/mozilla-b2g/gaia/commit/5d6adc93bef9ab3ac4ccfb2be4f0ce69453989f2

https://travis-ci.org/mozilla-b2g/gaia/jobs/12372588

Comment 5

[Germán Toro del Valle (:gtorodelvalle)]

Attachment: 12787.html

Sorry guys! Really freaked out how that end up landing in master taking into consideration all the linting controls in the middle... I recall some rebasing and probably that was the cause. Well that was the cause but mainly myself precipitating about the merging, of course. 

This (and upcoming) times I'll make sure that Travis talks before landing. Sorry again!

Comment 6

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/8538dac23e3d3416025824f3f27b3f99c37c40fe

Comment 7

[Joe Cheng [:jcheng] (please needinfo)]

triage: koi+ regression

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 8538dac23e3d3416025824f3f27b3f99c37c40fe
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 9

[Germán Toro del Valle (:gtorodelvalle)]

Hi John, you were completely right. There is a dependency we forgot to include in the bug. The point is that we are still trying to get Ayman's confirmation about the bug 925307 's patch. As soon as I get his confirmation I will ask for the v1.2 approval and once granted cherry picking bug 925307 's patch before this one will work just fine. I just verified it ;-)

Thank you very much.

Comment 10

[Germán Toro del Valle (:gtorodelvalle)]

Since bug 925307 has just been uplifted to v1.2, everything should go fine now... John, would you be so kind to give it a new try to the cherry picking? If you prefer me to do it, just need-info me, please. Thanks!

Comment 11

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 8538dac23e3d3416025824f3f27b3f99c37c40fe to:
v1.2: 819087cd3bb2de9c2afdbfca15496ea02968f9f4

Comment 12

[isabelrios]

Verified v1.2 11/06 build:

Gecko-e612f4f
Gaia-b12d548