92500 - OmniWeb browser "corrupts" params file with hard returns (^M)

Status: RESOLVED FIXED

(Bugzilla :: Administration, task, P1)

Description

[Allan Streib]

When updating parameters using the OmniWeb web browser for Mac OS X, the browser
apparently submits hard returns (^M) instead of newlines for textarea stuff.  So
for example, I get a hard returns in the newchangedmail headers after the
"From:" header which makes sendmail (8.11.4) barf (it thinks there's no
recipient)

See also bug report 89211 which helped me solve the error, and now I know where
it's coming from.

Not sure if this is considered a browser bug or a Bugzilla bug, but it would be
a quick fix to doeditparams.cgi to strip these out (looks like it's already
translating \r\n to \n).

Comment 1

[Dave Miller [:justdave]]

I think this is related to another bug, but I'll leave it here for now until we 
get a little closer to 2.16 on triage :)

I use Omniweb and have run into this on other browsers besides Omniweb also, so I 
think this is at least partially a Bugzilla problem.  I know CR-delimited is 
legal according to the w3c spec.

Comment 2

[Matthew Tuck [:CodeMachine]]

*** Bug 92409 has been marked as a duplicate of this bug. ***

Comment 3

[Steve Dagley]

Changed comment since this bug is showing up in my query for OS X Mozilla bugs

Comment 4

[Dave Miller [:justdave]]

I can't read the whole summary in the buglist if you do that.  Try limiting your
query to the Browser product if you only want Mozilla bugs.

Comment 5

[Dave Miller [:justdave]]

correcting version field lost in product move

Comment 6

[Dave Miller [:justdave]]

*** Bug 89211 has been marked as a duplicate of this bug. ***

Comment 7

[Florian Kolbe]

Just to confirm,
same happened to me using Opera 5.0 on Linux (Bugzilla 2.14), perl 5.61.
To be really safe, newchangedmail and passwordmail should be seperated
into seperate fields (it's too easy to screw up the mail templates).
I guess I'm not the first to propose that.

Comment 8

[Dave Miller [:justdave]]

Florian: not sure what you're suggesting here.  Those two mail fields are
already separate??

Comment 9

[Matthew Tuck [:CodeMachine]]

I think that might mean two different pages.

We might want to templatise these email parameters for 2.16 and skip fixing this
directly.  Admins would lose the ability to edit it online but I don't think
that's a major problem - if it was we could provide a facility to edit all
templates.

Comment 10

[Florian Kolbe]

I wanted to suggest that the param 'newchangedmail' itself would be split
up into seperate params 'newchangedmail_from', 'newchangedmail_body' et al.

Also, the same 'from'-Param could be used for all mail types (now you have to
change 'bugzilla-daemon' three or four times).

Something like:
'automatic_from_address' - 'From:'-Field for generated mails (processmail)
'newchangedmail_body'
'passwordmail_body'
'voteremovedmail_body'

I dont think you'd need to fiddle with the 'To:' field at all?

But I guess it would not be flexible enough any more?

Comment 11

[Dave Miller [:justdave]]

Yeah, the To: field gets fiddled with constantly on the test sites...

For example, if you're testing something, and needed to see what the email
looked like, but didn't want mail to go out to all your users, you could make
your header look like this:

To: [e-mail]
X-Real-To: %to%

Then the mail would all go to you, but you'd have a header telling you who it
would have gone to.

Comment 12

[Dave Miller [:justdave]]

This is going to be a blocker for the 2.16 release

Comment 13

[Gervase Markham [:gerv]]

Attachment: Patch v.1

Would this do the trick?

Gerv

Comment 14

[Gervase Markham [:gerv]]

Taking.

Gerv

Comment 15

[Gervase Markham [:gerv]]

Accepting.

Gerv

Comment 16

[David D. Kilzer (ddk)]

r=ddk

Comment 17

[David D. Kilzer (ddk)]

Comment on attachment 57552 [details] [diff] [review]
Patch v.1

Looks good!

Comment 18

[Dave Miller [:justdave]]

Comment on attachment 57552 [details] [diff] [review]
Patch v.1

Looks good to me.

Comment 19

[Dave Miller [:justdave]]

checked in.

/cvsroot/mozilla/webtools/bugzilla/doeditparams.cgi,v  <--  doeditparams.cgi
new revision: 1.16; previous revision: 1.15