Closed Bug 925003 Opened 7 years ago Closed 6 years ago

Ensure SMS messages in only uppercase Greek letters are sent with 7bit encoding on the carrier partner network

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect, P1)

defect

Tracking

(blocking-b2g:koi+, b2g18 unaffected, b2g-v1.1hd unaffected, b2g-v1.2 fixed)

RESOLVED FIXED
1.2 C3(Oct25)
blocking-b2g koi+
Tracking Status
b2g18 --- unaffected
b2g-v1.1hd --- unaffected
b2g-v1.2 --- fixed

People

(Reporter: julienw, Assigned: rudyl)

References

Details

Attachments

(1 file)

Implement Bug 914454 for 1.2 and master. 

If we don't do it in 1.2 we'll regress since bug 914454 is in 1.1.
Next steps? Is this a l10n issue?
Flags: needinfo?(felash)
Next step is to do what we did in Bug 914454 in master and 1.2 in the keyboard app. We might need to do some adjustment in the Sms app too (especially the name of the inputmode as the one used in Bug 914454 is not the best one imo :) ).

This is a blocker for the Greek market according to DT.
Flags: needinfo?(felash)
(In reply to Julien Wajsberg [:julienw] from comment #2)
> Next step is to do what we did in Bug 914454 in master and 1.2 in the
> keyboard app. We might need to do some adjustment in the Sms app too
> (especially the name of the inputmode as the one used in Bug 914454 is not
> the best one imo :) ).
> 
> This is a blocker for the Greek market according to DT.

I am confused. Won't what landed to v1.2 and master in bug 914454 work?
Flags: needinfo?(rlu)
Flags: needinfo?(felash)
Tim, the keyboard part from bug 914454 did not land in master and 1.2. (or am I wrong here ?)
Flags: needinfo?(felash)
Right, so we need 

https://github.com/mozilla-b2g/gaia/commit/735d9f7871d4352989c54ce7143c8a0163f3418f

on master.

This is really confusing....
blocking-b2g: koi? → koi+
Right, with imho some changes that I outlined in bug 914454 comment 107 (using mutation events, and changing the inputmode name).
Sorry about causing the confusion.
This is partially because the keyboard part of Bug 914454 is a quick fix for v1.1 only and at that time we think we will have a thorough solution for v1.2 (and of course a different patch).

But since we also comes to an end for v1.2, maybe we need to migrate the same solution there to v1.2 and master first. Will try to make that happen soon.
Flags: needinfo?(rlu)
Assignee: nobody → rlu
Target Milestone: --- → 1.2 C3(Oct25)
(In reply to Julien Wajsberg [:julienw] from comment #6)
> Right, with imho some changes that I outlined in bug 914454 comment 107
> (using mutation events, and changing the inputmode name).

I think we are safe to "downlift" the Greek SMS keyboard to v1.2/master but adding the mutation observer to detect the inputmode change. Please file another bug for that.

Rudy is this *the* bug you are working on today? If not tell me exactly what to do so people could steal this bug.
Flags: needinfo?(rlu)
I'm going to send a patch for this today.
Thank you.
Status: NEW → ASSIGNED
Flags: needinfo?(rlu)
?
Flags: needinfo?(rlu)
Hi David,

This is basically Bug 914454 and 927321, but for master and v1.2
Please help take a look at this patch.

Thank you.

--
Tim,

Sorry for being late to provide the patch.
Attachment #822722 - Flags: review?(dflanagan)
Flags: needinfo?(rlu)
Comment on attachment 822722 [details] [review]
github pull request 13110

Julien,

Please help to review the SMS app part about the renaming of inputmode from "-moz-sms-7bit" to "-moz-sms".

Thanks.
Attachment #822722 - Flags: review?(felash)
> but adding the mutation observer to detect the inputmode change.
> Please file another bug for that.

Do you mean I should file another bug for adding the mutation observer ?
Note that without the mutation observer, one case is not working as expected, when the user switches from SMS to MMS and vice versa.
Comment on attachment 822722 [details] [review]
github pull request 13110

r=me for the SMS part, but i'd really want to have the mutation observer implemented here.
Attachment #822722 - Flags: review?(felash) → review+
Comment on attachment 822722 [details] [review]
github pull request 13110

I still wish we could just have an SMS layout available on the greek keyboard and just alow the user to select that layout when the need it.

But I guess this approach is what we have to do for now.

See my comments on github, but basically, this looks fine to me.
Attachment #822722 - Flags: review?(dflanagan) → review+
Gaia master,
https://github.com/mozilla-b2g/gaia/commit/50c5c530ffef00cb7b24d00e23cbed80210105d2
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
See Also: → 914454
Rudy, would you please file a bug for the mutation event change ? I think you're the best one to describe what's needed :)
Flags: needinfo?(rlu)
Depends on: 933637
Not a dependency of this bug.
No longer depends on: 933637
Julien, thanks for the reminding.
Bug 933637 filed to track this.
Flags: needinfo?(rlu)
See Also: → 995915
You need to log in before you can comment on or make changes to this bug.