925005 - Inclusion of moztest breaks mach b2g desktop mochi tests

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Patch 1 (v1) - Add moztest module path to mach search paths

New moztest module was added for marionette (bug 879900) but not added to mach search paths.

Comment 1

[Andrew Halberstadt [:ahal]]

We should really be pulling these from testing/mozbase/packages.txt or similar

Comment 3

[Jeff Hammel]

(In reply to Andrew Halberstadt [:ahal] from comment #1)
> We should really be pulling these from testing/mozbase/packages.txt or
> similar

+1 ; we even have the option (which I believe is currently enforced, maybe?) of unrolling the deps correctly if it makes a difference (which it shouldn't here, fwiw).

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 814982 [details] [diff] [review]
Patch 1 (v1) - Add moztest module path to mach search paths

Review of attachment 814982 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, the sys.path foo in mach_bootstrap.py is currently a giant hack. Ironing out virtualenv integration issues with mach is on my long todo list and sadly isn't near the top.

We should schedule a meeting to talk about how to do this right. For now, easy r+.

Comment 5

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

https://hg.mozilla.org/integration/b2g-inbound/rev/57d2846362d9

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/57d2846362d9