Closed Bug 925043 Opened 11 years ago Closed 10 years ago

Redesign TOC has a bunch of empty <code> tags in markup

Categories

(developer.mozilla.org Graveyard :: General, defect)

Product:
developer.mozilla.org Graveyard
Component:
General
Platform:
All
Other
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: pdehaan, Unassigned)

References

Details

(Whiteboard: [specification][type:bug]) 

What did you do?
================
1. Go to view-source:https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp#Special_characters_in_regular_expressions
2. Search for `<code></code>` in the source code.


What happened?
==============
about 192 matches (looks like they're all in the TOC).

What should have happened?
==========================
No matches, presumably.

Is there anything else we should know?
======================================
I love you. <3
Blocks: 910513
Blocks: 927422
No longer blocks: 910513
These extra tags, while annoying, aren't taking up any space and aren't visible.  I would think we shouldn't block on this.
I agree with David on this. Up to Ali for the final decision (Peter: on blocking, not on fixing, we all agree it is a bug!)
Flags: needinfo?(aspivak)
Yup, does not block the launch.
Flags: needinfo?(aspivak)
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/6ec5b691c565b375ad5f9664bacb9a5acd7f9334
Fix Bug 925043 - TOC contains empty <code> tags

https://github.com/mozilla/kuma/commit/9523f9402fdb0ceea6d50ce5075682c3d98b8e57
Merge pull request #2162 from mediocrity/remove-redundant-tags

Fix Bug 925043 - TOC contains empty <code> tags
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.