925199 - Move touch-events.js to /toolkit/

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect, P1)

Comment 1

[Paul Rouget [:paul]]

Attachment: Patch V1

Comment 2

[Paul Rouget [:paul]]

Code of touch-events.js has changed.

Comment 3

[Paul Rouget [:paul]]

Alex, can you also make sure that the simulator uses this file?

Comment 4

[Alexandre Poirot [:ochameau]]

Comment on attachment 815211 [details] [diff] [review]
Patch V1

Review of attachment 815211 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/Loader.jsm
@@ +59,5 @@
>          "devtools/toolkit/webconsole": "resource://gre/modules/devtools/toolkit/webconsole",
>          "devtools/app-actor-front": "resource://gre/modules/devtools/app-actor-front.js",
>          "devtools/styleinspector/css-logic": "resource://gre/modules/devtools/styleinspector/css-logic",
>          "devtools/css-color": "resource://gre/modules/devtools/css-color",
> +        "devtools/touch-events": "resource://gre/modules/devtools/touch-events",

Why don't we add a toolkit mapping (or something) and stop doing specifics for each new module we want to access from devtools/toolkit.
This really doesn't scale. Is there anything planned for the merge of browser/devtools and toolkit/devtools regarding loader require paths?

Comment 5

[Alexandre Poirot [:ochameau]]

To make it work on the simulator, we just need to update gaia, see bug 925289.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alexandre Poirot (:ochameau) from comment #4)
> Why don't we add a toolkit mapping (or something) and stop doing specifics
> for each new module we want to access from devtools/toolkit.
> This really doesn't scale. Is there anything planned for the merge of
> browser/devtools and toolkit/devtools regarding loader require paths?

I agree, it is definitely getting crazy...  Plus, people tend to forget to update the SrcdirProvider each time they add a new custom entry too.

I feel like people might be waiting for devtools to move to top-level, but perhaps there is something we can do to improve this in the short term.  Seems reasonable enough to just define "devtools/toolkit", remove all the other toolkit entries, and then go update the calls.

Comment 7

[Paul Rouget [:paul]]

I agree with both of you. Can we do that in a follow-up? This patch is ready and is important.

Comment 8

[Paul Rouget [:paul]]

Follow-up: bug 925692

Comment 9

[Alexandre Poirot [:ochameau]]

Comment on attachment 815211 [details] [diff] [review]
Patch V1

Review of attachment 815211 [details] [diff] [review]:
-----------------------------------------------------------------

We can clean up the other requires in followups, I even encourage to do that.
But it would be great to have the final require path (implemented in a sane way) for this module,
so that we can land a fix in gaia only once.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/5836dc9eaa65

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5836dc9eaa65

Comment 12

[Paul Rouget [:paul]]

Comment on attachment 815211 [details] [diff] [review]
Patch V1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new feature (touch events simulation)
User impact if declined: can't use touch events with non-Firefox builds (B2G desktop for example)
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): low (moving a file)
String or IDL/UUID changes made by this patch: none

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/bbea2bbc46ea