925272 - Test failure "Current URL should be identical to the target URL" in /testSecurity/testSafeBrowsingWarningPages.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Description

[Cosmin Malutan, [:cosmin-malutan]]

This failed a lot today with nightly, and it reproduces every time, so i think we should skip this tests until we find the root, all locales are affected on all machine .
It passes with the previous build so it could be a regression.

http://mozmill-daily.blargon7.com/#/remote/report/6d6f6a58b02eeffc06eafa8beaac087e

Comment 1

[mario garbi]

Attachment: skip.patch

Skip patch until we can find a fix. I have also updated the manifest with a change that I missed in Bug 905033, sorry about that.

I can locally reproduce this and will look into it.

Comment 2

[mario garbi]

Attachment: skip v2

Removed that changes to the manifest as I will make a separate patch for that.

Comment 3

[Andrei Eftimie]

Comment on attachment 815262 [details] [diff] [review]
skip v2

Review of attachment 815262 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good,
Disabled: http://hg.mozilla.org/qa/mozmill-tests/rev/c4bb2af1c011 (default)

Does indeed looks like a genuine regression,
please find a regression range using inbound builds.

Comment 4

[mario garbi]

The problem here is that Services.urlFormatter.formatURLPref(prefName) that we use in utils to gather the url is using a deprecated //@ as can be seen by the console error below:

JavaScript warning: https://support.cdn.mozilla.net/static/js/common-min.js?build=2a09b72, line 2: Using //@ to indicate sourceMappingURL pragmas is deprecated. Use //# instead

Using dumps I noticed that the "url" parameter that we send to check with utils.assertLoadedUrlEqual is either "about:blank" or "about:home" and as such confirms the above.

I will further look into this.

Comment 5

[mario garbi]

The problem was actually with a preference that got removed, that we used to get the url in that function:
"browser.safebrowsing.warning.infoURL"
https://hg.mozilla.org/mozilla-central/rev/da823cb1e924#l2.12

Changeset:
http://hg.mozilla.org/mozilla-central/rev/da823cb1e924

I will replace the old preference with the new one and come with a fix patch.

Comment 6

[Henrik Skupin [:whimboo][⌚️UTC+2]]

That totally explains why we are getting redirected to SUMO now. Thanks Mario!

Comment 7

[mario garbi]

Attachment: patch v1

We updated the method to gather the right url now that we no longer have that preference.

Mac
http://mozmill-crowd.blargon7.com/#/remote/report/6d6f6a58b02eeffc06eafa8beac453b4
http://mozmill-crowd.blargon7.com/#/remote/report/6d6f6a58b02eeffc06eafa8beac46a08

Linux:
http://mozmill-crowd.blargon7.com/#/remote/report/6d6f6a58b02eeffc06eafa8beac40090
http://mozmill-crowd.blargon7.com/#/remote/report/6d6f6a58b02eeffc06eafa8beac41f5b

Windows:
http://mozmill-crowd.blargon7.com/#/remote/report/6d6f6a58b02eeffc06eafa8beac3b974
http://mozmill-crowd.blargon7.com/#/remote/report/6d6f6a58b02eeffc06eafa8beac3cf72

Comment 8

[Andrei Eftimie]

Comment on attachment 815350 [details] [diff] [review]
patch v1

Review of attachment 815350 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks Mario for the quick investigation and fix!

Landed: http://hg.mozilla.org/qa/mozmill-tests/rev/5eb11ce0db8f (default)