925349 - Figure out if we can improve the draggable toolbar XBL story

Status: RESOLVED INVALID

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

(In reply to :Gijs Kruitbosch from bug 909366 comment #2)
> - (I don't understand why) we have separate functional toolbar bindings
> depending on the lwtheme:
> https://mxr.mozilla.org/projects-central/source/ux/browser/themes/windows/
> browser-aero.css#188
> (https://bugzilla.mozilla.org/show_bug.cgi?id=803546#c12)
> - We could potentially toggle draggability of toolbars in the same binding,
> using an attribute or property or something, which makes more sense to me
> than having separate bindings for it (although that's partially because
> XBL's inheritance model isn't great)

Per bug 555081, Dão, do you know about this? I've read some of the comments, but I'm not sure I follow why we treat lwthemes differently here.

Comment 1

[Dão Gottwald [:dao]]

(In reply to :Gijs (not here until monday) from comment #0)
> (In reply to :Gijs Kruitbosch from bug 909366 comment #2)
> > - (I don't understand why) we have separate functional toolbar bindings
> > depending on the lwtheme:
> > https://mxr.mozilla.org/projects-central/source/ux/browser/themes/windows/
> > browser-aero.css#188
> > (https://bugzilla.mozilla.org/show_bug.cgi?id=803546#c12)

Because lightweight themes covered up the title bar, so we wanted to treat the whole surface consistently. Bug 1387415 removed this distinction.

> > - We could potentially toggle draggability of toolbars in the same binding,
> > using an attribute or property or something, which makes more sense to me
> > than having separate bindings for it (although that's partially because
> > XBL's inheritance model isn't great)

Using a binding allows us to toggle this from CSS. Today we only use the toolbar-drag binding on Linux, and -moz-window-dragging elsewhere.