Closed
Bug 925530
Opened 11 years ago
Closed 10 years ago
Set `antialias` to `false` on mobile
Categories
(Core :: Graphics: CanvasWebGL, defect)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla33
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
Attachments
(2 files)
1.99 KB,
patch
|
u480271
:
review+
vlad
:
review+
|
Details | Diff | Splinter Review |
2.40 KB,
patch
|
jgilbert
:
review+
|
Details | Diff | Splinter Review |
One reason we haven't worked on enabling AA on mobile before is that it's not cheap for the already-taxed hardware, and also it doesn't matter as much, given the pixel densities on mobile devices. However, after bug 922368, we're likely to have AA working on GLES3 mobile devices. Since aa defaults to `true` for webgl contexts, this means that many demos will suddenly run slower on these devices. One thing we've discussed in the past is forbidding AA contexts on mobile (within spec) or defaulting to `false` on mobile. (non-spec) I think we should try to respec this such that the default for `antialias` can be device dependent. This way, things continue at the same speed as before, but apps which deliberately opt into antialiasing would get better quality. If we just fix AA for mobile, I anticipate a number of bugs about FF being suddenly slower, or slower than X other browser on a number of devices. It's not a fun path, but it's also handle-able. (if annoying)
Assignee | ||
Comment 1•11 years ago
|
||
Thoughts?
Status: NEW → UNCONFIRMED
Ever confirmed: false
Flags: needinfo?(vladimir)
Assignee | ||
Updated•11 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Is this still an issue? I absolutely agree that it should default to false on mobile hardware, regardless of what the spec says.
Flags: needinfo?(vladimir)
Assignee | ||
Comment 3•10 years ago
|
||
The spec says it should default to true. I'll try to get this changed.
Assignee | ||
Updated•10 years ago
|
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 4•10 years ago
|
||
Alright, the WG didn't like having a different default. For the time being, I think we'd rather have antialiasing nowhere on mobile, rather than have it sometimes pop up and tank performance. Mobile generally much higher DPI than desktops, so antialiasing is worth less anyways. Also, on memory-bandwidth-constrained devices (most all mobile), handing a huge MSAA buffer is going to be extremely harmful to performance.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(jgilbert)
Summary: Set mobile default for `antialias` to `false` → Set `antialias` to `false` on mobile
Assignee | ||
Comment 5•10 years ago
|
||
Getting normal review from :kamidphish, but since this is a fairly impactful trade-off for Games, requesting review of the concept by :vlad.
Attachment #8449039 -
Flags: review?(vladimir)
Attachment #8449039 -
Flags: review?(dglastonbury)
Attachment #8449039 -
Flags: review?(vladimir) → review+
Comment on attachment 8449039 [details] [diff] [review] patch: No default mobile antialias Review of attachment 8449039 [details] [diff] [review]: ----------------------------------------------------------------- LGTM
Attachment #8449039 -
Flags: review?(dglastonbury) → review+
Assignee | ||
Comment 7•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/63e44c0641c3
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/d90688dc9c51 for build bustage: https://tbpl.mozilla.org/php/getParsedLog.php?id=42986184&tree=Mozilla-Inbound
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 9•10 years ago
|
||
I forgot an include in the reviewed one.
Attachment #8449909 -
Flags: review+
Flags: needinfo?(jgilbert)
Assignee | ||
Comment 10•10 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=bdf931d51e2a
Assignee | ||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/efc7e30c8eae
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/efc7e30c8eae
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
You need to log in
before you can comment on or make changes to this bug.
Description
•