Closed Bug 925534 Opened 6 years ago Closed 6 years ago

Convert toVariant to use handles

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: sfink, Assigned: sfink)

References

Details

Attachments

(1 file)

For this hazard:

Function 'uint8 mozilla::jsipc::JavaScriptChild::fail(JSContext*, mozilla::jsipc::ReturnStatus*)' has unrooted '__temp_14' of type 'JS::Value' live across GC call 'mozilla::jsipc::ReturnException* mozilla::jsipc::ReturnStatus::get_ReturnException()' at js/ipc/JavaScriptChild.cpp:135
    js/ipc/JavaScriptChild.cpp:135: Call(30,31, __temp_17 := rs*.get_ReturnException())
    js/ipc/JavaScriptChild.cpp:135: Call(31,32, __temp_16 := __temp_17*.exn())
    js/ipc/JavaScriptChild.cpp:135: Call(32,33, __temp_13 := this*.field:1.toVariant(cx*,__temp_14*,__temp_16*))
Attachment #815603 - Flags: review?(terrence)
Blocks: 898606
Comment on attachment 815603 [details] [diff] [review]
Convert toVariant to use handles

Review of attachment 815603 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. r=me
Attachment #815603 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/f6b879837822
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.