925546 - Rename TopSitesGridView.OnPinSiteListener to OnEditSiteListener

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Or something similar, in addition to changing the names of the implementing interfaces.

The long press context menu for a top sites thumbnail has two pinned site editing options, "Edit" and "Pin Site". "Pin Site" does not use the OnPinSiteListener code path at all [1] whereas "Edit" does [2]. The name currently implies the latter option so I feel it is unintuitive.

I okayed this change with the code's original author.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/TopSitesPage.java?rev=c96a2d66725c#326
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/TopSitesPage.java?rev=c96a2d66725c#392

Comment 1

[Lucas Rocha (:lucasr)]

Makes sense.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: 01: OnPinSiteListener -> OnEditPinnedSiteListener

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: 01b: OnPinSiteListener -> OnEditPinnedSiteListener

Rebase, move r+.

https://hg.mozilla.org/integration/fx-team/rev/8254d15a537d

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8254d15a537d