Rename TopSitesGridView.OnPinSiteListener to OnEditSiteListener

RESOLVED FIXED in Firefox 27

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

27 Branch
Firefox 27
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Or something similar, in addition to changing the names of the implementing interfaces.

The long press context menu for a top sites thumbnail has two pinned site editing options, "Edit" and "Pin Site". "Pin Site" does not use the OnPinSiteListener code path at all [1] whereas "Edit" does [2]. The name currently implies the latter option so I feel it is unintuitive.

I okayed this change with the code's original author.

[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/TopSitesPage.java?rev=c96a2d66725c#326
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/TopSitesPage.java?rev=c96a2d66725c#392
Component: General → Awesomescreen
Makes sense.
Created attachment 817564 [details] [diff] [review]
01: OnPinSiteListener -> OnEditPinnedSiteListener
Attachment #817564 - Flags: review?(sriram)
Attachment #817564 - Flags: review?(sriram) → review+
Created attachment 817927 [details] [diff] [review]
01b: OnPinSiteListener -> OnEditPinnedSiteListener

Rebase, move r+.

https://hg.mozilla.org/integration/fx-team/rev/8254d15a537d
Attachment #817564 - Attachment is obsolete: true
Attachment #817927 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/8254d15a537d
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
You need to log in before you can comment on or make changes to this bug.