Closed
Bug 925546
Opened 11 years ago
Closed 11 years ago
Rename TopSitesGridView.OnPinSiteListener to OnEditSiteListener
Categories
(Firefox for Android Graveyard :: Awesomescreen, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 27
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(1 file, 1 obsolete file)
9.31 KB,
patch
|
mcomella
:
review+
|
Details | Diff | Splinter Review |
Or something similar, in addition to changing the names of the implementing interfaces.
The long press context menu for a top sites thumbnail has two pinned site editing options, "Edit" and "Pin Site". "Pin Site" does not use the OnPinSiteListener code path at all [1] whereas "Edit" does [2]. The name currently implies the latter option so I feel it is unintuitive.
I okayed this change with the code's original author.
[1]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/TopSitesPage.java?rev=c96a2d66725c#326
[2]: https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/home/TopSitesPage.java?rev=c96a2d66725c#392
Assignee | ||
Updated•11 years ago
|
Component: General → Awesomescreen
Comment 1•11 years ago
|
||
Makes sense.
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #817564 -
Flags: review?(sriram)
Updated•11 years ago
|
Attachment #817564 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Rebase, move r+.
https://hg.mozilla.org/integration/fx-team/rev/8254d15a537d
Attachment #817564 -
Attachment is obsolete: true
Attachment #817927 -
Flags: review+
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 27
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•