925621 - Let startProfiling take a pid so the content process can be profiled

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Drew Willcoxon :adw]

Attachment: patch2.diff

I needed to get an Instruments.app profile of a particular part of a content script, but {start,stop}Profiling aren't available there.  I don't know how to make them available or if there's some alternative, so as a workaround I messaged the parent and used this patch, in combination with MOZ_DEBUG_CHILD_PROCESS to get the content pid.

This was useful for me, but it's kind of awkward so I understand if you don't want to take it.

(Not sure who to r?... Steve reviewed the original patch in bug 748669 and pops up as a "suggested reviewer," so Steve it is.)

Comment 1

[Steve Fink [:sfink] [:s:]]

Comment on attachment 815714 [details] [diff] [review]
patch2.diff

Review of attachment 815714 [details] [diff] [review]:
-----------------------------------------------------------------

Oops, sorry! This review slipped through the cracks. Looks good to me, and I'm assuming it works when you try it.

Comment 2

[Drew Willcoxon :adw]

Thanks, Steve.

https://hg.mozilla.org/integration/mozilla-inbound/rev/712758b52e76

Comment 3

[Drew Willcoxon :adw]

Backed out for Linux build bustage.  I should have pushed to try first. :-(

https://hg.mozilla.org/integration/mozilla-inbound/rev/a70124509785

Comment 4

[Drew Willcoxon :adw]

Attachment: fix Linux and Windows compiler errors

The Linux compiler error was that pid_t in Profilers.h was undeclared.  There were also Windows compiler errors due to pid_t and getpid being undeclared.  So this typedefs pid_t and #defines getpid on Windows (which is done in some other places in the tree), and otherwise #includes <unistd.h>.

https://tbpl.mozilla.org/?tree=Try&rev=053e0a019006

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d548421e14c5

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d548421e14c5