Upgrade httpd.js for speed-up fixes on bug 777354

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Details

(Whiteboard: [mozmill-2.0.1+][1.5.24+])

Attachments

(2 attachments)

With the fixes on bug 777354 we will get a massive speed-up of mozmill tests if those are using the same page served multiple times. That would have been very important for Mozmill 1.5 but given that this branch is dead, we only want to land it on master and hotfix-2.0.

File which has to be used for the update:
http://mxr.mozilla.org/mozilla-central/source/netwerk/test/httpserver/httpd.js
Created attachment 815824 [details] [diff] [review]
Patch v1
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #815824 - Flags: review?(dave.hunt)
Attachment #815824 - Flags: review?(dave.hunt) → review+
Landed as:
https://github.com/mozilla/mozmill/commit/99d183aba0b61b87b90d23c549aee70392c3e911 (master)
https://github.com/mozilla/mozmill/commit/984165cc66f0b030fe2121deb075f2319bbe513d (hotfix-2.0)

As testruns have been shown the time difference for Mozmill 2.0 is minimal at this point, because we only shutdown httpds.js once at the very end.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
We decided to push a very very last release for 1.5.24 by including a patch of this fix.
Whiteboard: [mozmill-2.0.1+] → [mozmill-2.0.1+][1.5.24?]
Created attachment 816717 [details] [diff] [review]
Patch (mozmill-1.5)

That's the patch for Mozmill 1.5. Can anyone please get this tested? Please share the work across platforms and branches. Thanks.
Attachment #816717 - Flags: review?(dave.hunt)
Attachment #816717 - Flags: feedback?(mario.garbi)
Attachment #816717 - Flags: feedback?(cosmin.malutan)
Attachment #816717 - Flags: feedback?(andrei.eftimie)
Attachment #816717 - Flags: feedback?(andreea.matei)

Comment 5

5 years ago
Comment on attachment 816717 [details] [diff] [review]
Patch (mozmill-1.5)

Review of attachment 816717 [details] [diff] [review]:
-----------------------------------------------------------------

All looking good on OSX and Windows 8. Still running tests on some older branches, but no failures until now. Will report back if I spot any.
Attachment #816717 - Flags: feedback?(andrei.eftimie) → feedback+
Comment on attachment 816717 [details] [diff] [review]
Patch (mozmill-1.5)

I runns well on Ubuntu 13.04 ,12.04 and Windows 7 with Nightly, I will keep running tests with more branches.
Attachment #816717 - Flags: feedback?(cosmin.malutan) → feedback+
Comment on attachment 816717 [details] [diff] [review]
Patch (mozmill-1.5)

Review of attachment 816717 [details] [diff] [review]:
-----------------------------------------------------------------

I've tested Aurora on Linux and all works fine there.
Attachment #816717 - Flags: feedback?(andreea.matei) → feedback+

Comment 8

5 years ago
I have tested it on Ubuntu 13.04 with Beta, Release, ESR24 and ESR17 using functional, remote, addons and endurance testruns and all worked fine.

Updated

5 years ago
Attachment #816717 - Flags: feedback?(mario.garbi) → feedback+
Comment on attachment 816717 [details] [diff] [review]
Patch (mozmill-1.5)

Review of attachment 816717 [details] [diff] [review]:
-----------------------------------------------------------------

Given that this is a straight update of httpd.js from mozilla-central and there's already been several confirmations of this working, r+
Attachment #816717 - Flags: review?(dave.hunt) → review+
Landed on hotfix-1.5 branch as:
https://github.com/mozilla/mozmill/commit/e3dd9c57aeaac7178111f67dc39f3dbad8a6c6aa
Whiteboard: [mozmill-2.0.1+][1.5.24?] → [mozmill-2.0.1+][1.5.24+]
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.