925632 - Upgrade httpd.js for speed-up fixes on bug 777354

Status: RESOLVED FIXED

(Testing Graveyard :: Mozmill, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the fixes on bug 777354 we will get a massive speed-up of mozmill tests if those are using the same page served multiple times. That would have been very important for Mozmill 1.5 but given that this branch is dead, we only want to land it on master and hotfix-2.0.

File which has to be used for the update:
http://mxr.mozilla.org/mozilla-central/source/netwerk/test/httpserver/httpd.js

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch v1

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed as:
https://github.com/mozilla/mozmill/commit/99d183aba0b61b87b90d23c549aee70392c3e911 (master)
https://github.com/mozilla/mozmill/commit/984165cc66f0b030fe2121deb075f2319bbe513d (hotfix-2.0)

As testruns have been shown the time difference for Mozmill 2.0 is minimal at this point, because we only shutdown httpds.js once at the very end.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We decided to push a very very last release for 1.5.24 by including a patch of this fix.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Patch (mozmill-1.5)

That's the patch for Mozmill 1.5. Can anyone please get this tested? Please share the work across platforms and branches. Thanks.

Comment 5

[Andrei Eftimie]

Comment on attachment 816717 [details] [diff] [review]
Patch (mozmill-1.5)

Review of attachment 816717 [details] [diff] [review]:
-----------------------------------------------------------------

All looking good on OSX and Windows 8. Still running tests on some older branches, but no failures until now. Will report back if I spot any.

Comment 6

[Cosmin Malutan, [:cosmin-malutan]]

Comment on attachment 816717 [details] [diff] [review]
Patch (mozmill-1.5)

I runns well on Ubuntu 13.04 ,12.04 and Windows 7 with Nightly, I will keep running tests with more branches.

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 816717 [details] [diff] [review]
Patch (mozmill-1.5)

Review of attachment 816717 [details] [diff] [review]:
-----------------------------------------------------------------

I've tested Aurora on Linux and all works fine there.

Comment 8

[mario garbi]

I have tested it on Ubuntu 13.04 with Beta, Release, ESR24 and ESR17 using functional, remote, addons and endurance testruns and all worked fine.

Comment 9

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Comment on attachment 816717 [details] [diff] [review]
Patch (mozmill-1.5)

Review of attachment 816717 [details] [diff] [review]:
-----------------------------------------------------------------

Given that this is a straight update of httpd.js from mozilla-central and there's already been several confirmations of this working, r+

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Landed on hotfix-1.5 branch as:
https://github.com/mozilla/mozmill/commit/e3dd9c57aeaac7178111f67dc39f3dbad8a6c6aa