925722 - Search suggestions require an extra tap to hit

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Ian Barlow (:ibarlow)]

At some point during our start page redesign, it looks like we changed the behaviour of our search suggestions such that now it requires two taps to trigger instead of just one. We should fix that. 

Expected: I type a few letters, and can tap on a search suggest tile and instantly trigger a search

Actual: I need to tap twice now: once to dismiss the keyboard, and once to trigger the search.

Comment 1

[Aaron Train [:aaronmt]]

Didn't even notice! Yeah, reproducible.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

I can't repro on my Galaxy Nexus, 4.2.2, FF 27 (Nightly).

Comment 3

[Aaron Train [:aaronmt]]

This seems fixed for me as well (10/15). Ian, are you still able to reproduce?

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Still repros for me using a 10/15 nightly. First tap hides the keyboard. Second does the suggestion.

Comment 5

[Ian Barlow (:ibarlow)]

Yep, still able to reproduce this as well. 

Nexus 4, Android 4.3, Nightly 10/16

Comment 6

[Lucas Rocha (:lucasr)]

Attachment: Handle touch events in HomeSearchListView with onTouchEvent (r=sriram)

Comment 7

[Lucas Rocha (:lucasr)]

Comment on attachment 823428 [details] [diff] [review]
Handle touch events in HomeSearchListView with onTouchEvent (r=sriram)

Apparently, touch event interception + requestFocus() don't go so well on ListViews.

Comment 8

[Lucas Rocha (:lucasr)]

https://hg.mozilla.org/integration/fx-team/rev/200fa2ac65e4

Comment 9

[Lucas Rocha (:lucasr)]

Comment on attachment 823428 [details] [diff] [review]
Handle touch events in HomeSearchListView with onTouchEvent (r=sriram)

[Approval Request Comment]
Bug caused by (feature/regressing bug #): new about:home (bug 862793)
User impact if declined: extra tap needed to trigger a search suggestions while the virtual keyboard is on screen.
Testing completed (on m-c, etc.): local testing for now, let's bake this in Nightly for a few days and then uplift it.
Risk to taking this patch (and alternatives if risky): low, just changes the way to capture touch events to dismiss the virtual keyboard while showing awesomescreen search results. 
String or IDL/UUID changes made by this patch: n/a

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/200fa2ac65e4

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e2b3761232a0
https://hg.mozilla.org/releases/mozilla-beta/rev/4a4a0bc14e1b

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/4a4a0bc14e1b

Comment 13

[Teodora Vermesan (:TeoVermesan)]

Verified fixed on:
Build: Firefox for Android 27.0a2 (2013-12-06)
Device: Samsung Galaxy Nexus
OS: Android 4.2.1