Closed
Bug 92573
Opened 25 years ago
Closed 25 years ago
nsVoidArray -> nsAutoVoidArray changes for Layout
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
FIXED
mozilla0.9.5
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Keywords: perf)
Attachments
(2 files)
|
9.86 KB,
patch
|
Details | Diff | Splinter Review | |
|
9.65 KB,
patch
|
kinmoz
:
review+
kinmoz
:
superreview+
|
Details | Diff | Splinter Review |
Taken from bug 90545. I _really_ want to see these committed ASAP. The patch
will require that the phase 1 patch from that bug be applied/committed first.
| Assignee | ||
Comment 2•25 years ago
|
||
| Assignee | ||
Updated•25 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.5
Comment 3•25 years ago
|
||
Review Comments:
In nsCellMap.cpp, the method OrderRowGroups should be changed to take and
nsAutoVoidArray reference, and the following cast should be eliminated:
- aTableFrame.OrderRowGroups(orderedRowGroups, numRowGroups);
+ aTableFrame.OrderRowGroups((nsVoidArray &)orderedRowGroups, numRowGroups);
It seems bad to cast the nsVoidArray to an nsAutoVoidArray like that.
Other than that, the change looks good to me, but <paranoias> since table code
is so heavily involved, it might be good to run the table regression tests
</paranoias> [s]r=attinasi
| Assignee | ||
Comment 4•25 years ago
|
||
Given a review from attinasi, I'll try to get this for 0.9.4. Risk is low.
Target Milestone: mozilla0.9.5 → mozilla0.9.4
Comment 5•25 years ago
|
||
Randell, what about my comments?
| Assignee | ||
Comment 6•25 years ago
|
||
Sorry, I was going to post an updated patch, but I was waiting for it to compile
and test it first.
I simply removed the cast; it was a leftover and was irrelevant. C++ does the
type-conversion automatically.
| Assignee | ||
Comment 7•25 years ago
|
||
Ran every testcase I could find; no errors that weren't present before the patch
(I ran two side-by-side, one with one without).
| Assignee | ||
Comment 8•25 years ago
|
||
Attachment #47286 -
Flags: superreview+
Attachment #47286 -
Flags: review+
| Assignee | ||
Comment 10•25 years ago
|
||
Kin asked about possible bloat due to nsHTMLReflowCommands getting bigger. Here
are the stats I gathered:
nsHTMLReflowCommand->mPath stats:
Number created: 368
Number in-use max: 10
Num max size == 0: 0
Num max size <= 8: 298
Num max size > 8: 70
So the worst possible bloat is 32*10 = 320 bytes, but since ~80% of them use no
more than 8 items, and none use 0, the likely bloat is more like 64 bytes.
(This was loading and resizing each of mozilla.org, cnn.com, yahoo.com and
espn.com.)
I'm comitting this patch now.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
| Assignee | ||
Comment 11•25 years ago
|
||
*** Bug 80210 has been marked as a duplicate of this bug. ***
You need to log in
before you can comment on or make changes to this bug.
Description
•