Closed
Bug 925737
Opened 12 years ago
Closed 12 years ago
Copy constructor on webidl unions
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: jib, Assigned: bzbarsky)
References
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
8.77 KB,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
See bug 916012, comment 4.
Put a dictionary in a union with a boolean, or change a (boolean or object) to (boolean or MediaStreamConstraintsInternal) where the latter is a dictionary, and you get a result you can no longer copy in c++ (MOZ_DELETE is back).
|
Assignee | |
Comment 1•12 years ago
|
||
Attachment #815983 -
Flags: review?(peterv)
|
|
Assignee | |
Updated•12 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•12 years ago
|
Whiteboard: [need review]
|
|
Assignee | |
Comment 2•12 years ago
|
||
Note that (boolean or object) would still not be copy-constructible in this case.
|
Reporter | |
Comment 3•12 years ago
|
||
Understood, I was confused when I wrote the description, mixing MediaStreamConstraints and MediaStreamConstraintsInternal. Only the latter needs to be copyable and it didn't use union yet.
|
||
Updated•12 years ago
|
Attachment #815983 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Whiteboard: [need review]
Target Milestone: --- → mozilla28
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
|
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•