Closed
Bug 92576
Opened 25 years ago
Closed 25 years ago
nsVoidArray -> nsAutoVoidArray, all but content/layout from 90545
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla0.9.5
People
(Reporter: jesup, Assigned: jesup)
References
Details
(Keywords: perf)
Attachments
(2 files)
|
8.06 KB,
patch
|
Details | Diff | Splinter Review | |
|
9.97 KB,
patch
|
jesup
:
review+
jesup
:
superreview+
|
Details | Diff | Splinter Review |
All patches for nsVoidArray -> nsAutoVoidArray for modules other than content or
layout in bug 90545's second patch. Assumes the primary patch from 90545 has
been applied.
| Assignee | ||
Comment 1•25 years ago
|
||
I'll take this. module is really various, not xpcom.
| Assignee | ||
Comment 2•25 years ago
|
||
Comment 3•25 years ago
|
||
Any reason to not make nsRendericContextGTK::mStateCache a nsAutoVoidArray and
not a nsAutoVoidArray*, that way you'd cut down on yet one more allocation per
rendering context? Same goes for RDFContentSinkImpl::mContextStack?
Other than that, sr=jst
| Assignee | ||
Comment 4•25 years ago
|
||
Sure, mStateCache should be a member var. It's instantiated in the CTOR.
mContextStack I wasn't so sure about, because I didn't know how often we'd have
a push of context onto the stack. If we're pretty sure we always (usually) use
the context state, then no problem.
| Assignee | ||
Comment 5•25 years ago
|
||
| Assignee | ||
Updated•25 years ago
|
Attachment #47309 -
Flags: superreview+
Comment 6•25 years ago
|
||
r=waterson on the changes in mozilla/rdf.
| Assignee | ||
Comment 7•25 years ago
|
||
r= requests sent to darin, pavlov, kmcclusk, valeski, roc, and kin (for
different pieces of this patch).
Status: NEW → ASSIGNED
Regarding the transaction manager changes ... we need to keep in mind that every
text widget in the app (form/xul textfields, textareas, file input, and
passwords), as well as all flavors of Composer, have their own transaction
manager, and I believe all of them have only one listener registered.
Do we really want the extra 28 bytes overhead (7 unused pointer slots) for each
widget and Composer?
| Assignee | ||
Comment 9•25 years ago
|
||
Added these to the wrong bug:
have r=darin on netwerk/http portion via email
For uriloader portion via email: looks fine to me, r=darin
Kin writes:
>as well as all flavors of Composer, have their own transaction
>manager, and I believe all of them have only one listener registered.
>
>Do we really want the extra 28 bytes overhead (7 unused pointer slots) for each
>widget and Composer?
The overhead is 0 or negative (counting memory allocator overhead/rounding),
since currently all of those with their 1 listener have space for 8 allocated
(as soon as you add the first one, it allocates space for 8).
I'm strongly considering making another AutoVoidArray class that has a different
default (1); I can't make it specified easily due to the annoyances of C++ and
member var sizes. I also am considering allowing initializing VoidArray with an
array of any size. However, those are for the future.
Comment 10•25 years ago
|
||
r=kmcclusk@netscape.com for change to nsViewManager.h
Comment 11•25 years ago
|
||
r=kin@netscape.com for the TransactionManager changes.
| Assignee | ||
Comment 12•25 years ago
|
||
Has all reviews; will try to commit tonight
| Assignee | ||
Updated•25 years ago
|
Attachment #47309 -
Flags: review+
| Assignee | ||
Comment 13•25 years ago
|
||
Just checked, oops: we're waiting for Pav for the GFX review and then I can
check in.
Comment 14•25 years ago
|
||
other than the fact that the gfx/src/nsImage* files no longer exist, the gfx
part looks ok to me. r=pavlov
| Assignee | ||
Comment 15•25 years ago
|
||
Fix checked in (minus the files that were removed)
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•