925786 - Fix value editing in closures

Status: RESOLVED WONTFIX

(DevTools :: Debugger, defect, P5)

Description

[Panos Astithas (he/him) [:past] (please ni?)]

The closure inspection that landed recently doesn't work correctly for modifying the values of closed over variables. The problem is that there is a separate protocol request that should be used for that, "assign" and not "clientEvaluate". The client library already implements the protocol operation, we just need to have the frontend code track these nodes accordingly and send the right request in each case.

When said tracking is implemented, we could also remove the redundant and erroneous styling from closure environment labels as an added bonus.

Comment 1

[Jason Laster [:jlast]]

Closing as we no longer support editing variables, which means we do not need to do closure level edits. This was certainly a cool feature and perhaps we could pick it up in the future