925787 - separate fallback locale for fhr mobile from fhr desktop

Status: VERIFIED FIXED

(Firefox Health Report Graveyard :: Web: Health Report, defect)

Description

[Pascal Chevrel:pascalc]

We have fhr ready for almost all locales on Desktop but not for mobile, for example fhr Desktop translation in Polish is done while fhr mobile isn't yet. We have a lot more people involved on Desktop l10n than on mobile l10n actually so that's unlikely to change in the short term.

Currently it's a all or nothing situation, if we want to offer a fallback to English, that will make Desktop fallback to English too even though it's localized and shipped.

I am going to propose a patch for generate.py to fix that and allow us to have a locale activated for Desktop but with a separate fallback to another locale for mobile fhr.

Comment 1

[Pascal Chevrel:pascalc]

Attachment: Pointer to Github pull request: https://github.com/mozilla/fhr-jelly/pull/152

Pointer to Github pull-request

Comment 2

[Francesco Lodolo [:flod]]

Marking resolved since this pr was merged ages ago.

Comment 3

[Matt Brandt [:mbrandt]]

Suggestions for how to test this; I'm not entirely sure how to identify where (which locale) the fallback will occur?

Comment 4

[Francesco Lodolo [:flod]]

Wow, this bug is old, and the mobile version never made it to production :-\

Then only fallback is Japanese right now. 
https://github.com/pascalchevrel/fhr-jelly/blob/master/settings.py#L64

So, if you visit dev with a Japanese phone, you should see en-US content.

Comment 5

[Matt Brandt [:mbrandt]]

Awesome .. thx flod.

Comment 6

[Matt Brandt [:mbrandt]]

Oops .. didn't mean to ?needsinfo? you pascalc. Flod has me covered.

Bumping to QA verified on dev for /ja/ on Android. The fallback to /en-US/ correctly occurs. Looks like were ready for a prod release :)