925830 - Allow a Payment Account to be "shared"

Status: RESOLVED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect, P3)

Description

[Andy McKay]

We would like to have Payment Accounts shareable. That is a Payment Account can be used by anyone using the marketplace, so that other developers can use it. For example a registered charity. e.g. Mozilla Foundation.

This bug is about adding in a shared column on the payment account.

This column should only be set by Admin users once the account has been approved by us. So let's ensure that the API and the developer forms do not all the setting of this column.

Comment 1

[Bram Pitoyo [:bram]]

Hi Andy,

Making payment accounts shareable would “divorce” payment accounts from user accounts.

“Divorce” in the sense that each payment account is not tied in to any particular user.

So if before:
* User A creates payment account X
* User A can use, edit or delete payment account X

We are moving into the model where:
* User A creates payment account X
* User B can get access to payment account X
* User A can use, edit or delete
* User B can do…?

So I was wondering as to how the permission model will work?

Comment 2

[Bram Pitoyo [:bram]]

Attachment: marketplace devhub - display names, user types, team membership

Here’s a proposal I made in June about handling multiple users editing the same company name. This bug covers the same sort of problem, I think.

Comment 3

[Andy McKay]

(In reply to Bram Pitoyo [:bram] from comment #1)
> Making payment accounts shareable would “divorce” payment accounts from user
> accounts.
> 
> “Divorce” in the sense that each payment account is not tied in to any
> particular user.

Its still tied to a user, we are just making finer grained permissions about what a user can do with an account.

> * User B can do…?
> 
> So I was wondering as to how the permission model will work?

All User B can do is use the account. They can't edit, delete, view the reporting portal or anything else related to that account.

Comment 4

[Bram Pitoyo [:bram]]

After conversation with Andy, a checkbox that can be enabled/disabled by a Mozilla admin seems to be the best solution here. When a user wants an account to be made public, s/he should be able to contact our Admin, and we can review this request on a case-by-case basis.

Comment 5

[Andy McKay]

https://github.com/mozilla/zamboni/commit/1683bd7ec

Comment 6

[Andy McKay]

It's time to QA this, we've got an account from the Mozilla Foundation on prod. Here's how to QA it.

I've setup a fake special account on stage called "Test Foundation". A developer when setting up accounts can now choose to setup their own account, just like normal. When they do so its just like normal.

*optionally* they can choose to use the foundation shared account, like this:

https://www.dropbox.com/s/xv0hszyf7u00mey/Screenshot%202014-10-03%2017.10.48.png?dl=0

When they do that only one thing changes, when the app is bought (or an in-app payment is made), the money goes to the foundations account, not to the developers account.

So give this a try on stage, we'll verify the money gets paid to the fake foundation account, if that's all good, we'll repeat on prod.

Comment 7

[Andy McKay]

BTW I changed it to read "Donate to" instead of "Shared account:" because that's nicer.

https://github.com/mozilla/zamboni/commit/ad5ee9ff0228b90d4a715aa32b4c5bdadb78e16c

Comment 8

[krupa raj[:krupa]]

I set up an app with this account and made a purchase. Waiting for Andy to confirm before marking this as verified.