925923 - Simplify applying VariablesView changes without eval

Status: NEW

(DevTools :: Storage Inspector, defect, P3)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

VariablesView currently notifies its client of changes via methods like eval, switch, and delete, which are geared towards applying those changes by evaling strings.  

This is reasonable enough for remote objects, but we could have something less fragile for local objects.

Comment 1

[Brandon Benvie [:benvie]]

Yes, I'm finding the "add property" option is tremendously complicated by this.

Comment 2

[Victor Porof [:vporof][:vp]]

Keep in mind that any action on an object might affect other variables in scope or even the object itself in unforeseeable ways. This is why the variables view uses a client evaluation in scope, not simply setting the vale of a property or variable.

Comment 3

[Paul Rouget [:paul]]

Is it a thing we still want to do?

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Moving to the DOM panel as it's VariableView related and only the DOM panel uses the VariableView now

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

erratum: this should have been moved to the storage inspector, which is the last consumer of the variable view