92593 - Moving a bugs product removes all voters from the bug.

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P3)

Description

[Matthew Tuck [:CodeMachine]]

When you move a bug from one product to another, all the voters get removed from
the bug.

While this is often necessary because otherwise you could exceed your vote limit
per product, it is not always necessary.

Instead we could reduce people's votes to the highest value that:

(a) Means that the user's total vote count doesn't exceed what is allowed by the
product.
(b) Means that the user's bug vote count doesn't exceed what is allowed by the
product (see also bug #28882).

Of course often this might mean we reduce it to 0, and hence we remove them from
the bug.

Comment 1

[Matthew Tuck [:CodeMachine]]

Dave, we might want to fix this one for 2.14 as it'd be good for b.m.o to have
this fix when we create a Bugzilla product.

Comment 2

[Matthew Tuck [:CodeMachine]]

We should still send out an e-mail saying their vote has been reduced.  If it
needs to be removed entirely (because they're already reached their limit in
that product), we should send out the e-mail we do currently.

Comment 3

[Dave Miller [:justdave]]

yep, that do look like it.  Since the Bugzilla product as proposed currently 
allows more votes than webtools does, there shouldn't be any reductions 
necessary.  It'd be a good thing to have all the votes preserved.

Comment 4

[Jacob Steenhagen]

Attachment: patch

Comment 5

[Jacob Steenhagen]

The patch is largely untested (that is to say I tested a couple bits independant
of the bugzilla source and haven't tested it "in place"), but is now available
on Landfill for testing (see URL).

What it does is makes the user's votes fit into the per bug limit on a product
change (or policy change, for that matter) but doesn't do anything to make it
fit into the max per product limit (unless that limit is 0).  The user will be
forced to make thier votes fit inside the per-product limit the next time they
update their votes.

For Example:  
Broswer has a max of 10 (1 vote per bug limit)
Webtools has a max of 5 (5 votes per bug limit)

Let's say you have voted for 10 bugs in browser and there is a webtools bug that
you have commited 3 votes to.  If that webtools bug were to get moved to
browser, your votes on it would be reduced to 1 (you'd get an e-mail to that
effect), even though that'd make a total of 11 browser votes.  The next time you
try to update your votes, you'll be forced to get your votes in the browser
component down to 10.

Comment 6

[Dave Miller [:justdave]]

r= justdave.

it's in.

Comment 7

[Dave Miller [:justdave]]

I said FIXED, dangit

Comment 8

[Dave Miller [:justdave]]

Moving to Bugzilla product