Closed Bug 925933 Opened 11 years ago Closed 11 years ago

[Building Blocks] Update toggle switch BB visual design

Categories

(Firefox OS Graveyard :: Gaia, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia
Platform:
Other
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: caseyyee.ca, Assigned: caseyyee.ca)

References

Details

(Whiteboard: ux-tracking, visual design, jian)

Attachments

(3 files)

Switches&Sliders-Spec.zip
1.81 MB, application/zip
Details
Patch for Gaia/master
46 bytes, text/x-github-pull-request
arnau
: review+
Details | Review
bug-925933.jpg
525.40 KB, image/jpeg
Details 
Update toggle switches to new 1.3 visual design.
Flagging VD to post design to bug.
Flags: needinfo?(pabratowski)
Flags: needinfo?(pla)
Flags: needinfo?(pabratowski)
Whiteboard: ux-tracking → ux-tracking, visual design, jian
Priority: -- → P1
This is spec + animation I already emailed to Casey on Monday, but I'm posting it here to make it official.

Casey, ping me if you need to chat about exactly how to implement the animations, and we can discuss if adjustments are needed to make implementation go more smoothly.
Flags: needinfo?(pla)
OS: Mac OS X → Gonk (Firefox OS)
Hardware: x86 → Other
Attached file Patch for Gaia/master — 

        Attachment #8341456 -
        Flags: review?(epang)

    
    

    
  

      
      
      
      

        Attached image
          
        bug-925933.jpg
        — 
      

    


  
Screen shot of the patch in action.

Note: There are alignment issues that need to be separately addressed.   These are existing issues that are also present with the current BB toggle switch implementation

        Attachment #8341459 -
        Flags: review?(epang)

    
    

    
  
Comment on attachment 8341456 [details] [review]
Patch for Gaia/master

Hey Casey, I've just tested this.  The visuals look good, but the motion is still off.  Can you take a look at the video that Peter uploaded and replicate? Please re-flag me when ready.  Thanks!

        Attachment #8341456 -
        Flags: review?(epang) → review-

        Attachment #8341459 -
        Flags: review?(epang)

        Attachment #8341456 -
        Flags: review- → review?(arnau)

    
    

    
  
Myself, Eric and przemek reviewed the switches and everyone is on-board with the changes from a visual/motion design perspective. 

Arnau flagged for code review.

    
    

    
  
Comment on attachment 8341456 [details] [review]
Patch for Gaia/master

Everything ok, Thanks Casey!

        Attachment #8341456 -
        Flags: review?(arnau) → review+

    
    

    
  
Thanks Arnau :)

Merged to master: https://github.com/mozilla-b2g/gaia/commit/405ca7e016e14cc129450fcf835d5c5c059f7754
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
  
Assignee: nobody → kyee

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: