Closed
Bug 926070
Opened 11 years ago
Closed 11 years ago
Addref CacheFileIOManager while using it in its static methods
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla28
People
(Reporter: michal, Assigned: michal)
References
(Blocks 1 open bug)
Details
(Whiteboard: [qa-])
Attachments
(1 file)
|
6.38 KB,
patch
|
mayhemer
:
review+
michal
:
checkin+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #816247 -
Flags: review?(honzab.moz)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 816247 [details] [diff] [review]
fix
Review of attachment 816247 [details] [diff] [review]:
-----------------------------------------------------------------
One way, or (IMO better) to let any object using it just keep it a member. Like CacheFile::CacheFile() : mManager(gIOManger) { .. }. It's safer.
Up to you. I believe I have some places this needs to be ensured for the top level service as well. I'll audit and if needed report a bug.
Btw, when you define AddRef and Release using NS_IMPL_ISUPPORTSn you don't need (you shouldn't) MOZ_COUNT_CTOR/DTOR.
Attachment #816247 -
Flags: review?(honzab.moz) → review+
|
|
||
Updated•11 years ago
|
|
|
||
Comment 2•11 years ago
|
||
[ No longer blocks enabling cache2, expected to be fixed after cache2 is on ]
Blocks: cache2afterenable
|
|
||
Updated•11 years ago
|
No longer blocks: cache2enable
|
Assignee | |
Updated•11 years ago
|
Attachment #816247 -
Flags: checkin+
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
||
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
|
||
Updated•11 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•