926117 - When looking for strings with a comma in custom free-text fields, commas are used to split the query string

Status: NEW

(Bugzilla :: Query/Bug List, defect)

Description

[Frédéric Buclin]

I have a custom free-text field with "foo, bar" (without quotes) as text. In tabular reports, the link pointing to this text is correctly formatted but Search.pm splits the string on the comma and no data is returned, because instead of

COALESCE(bugs.cf_foo, '') IN ('foo, bar')

you get

COALESCE(bugs.cf_foo, '') IN ('foo', 'bar')

The culprit seems to be _all_values() or one of its callers.

Comment 2

[Simon Green]

Attachment: report-v2.patch

Comment 3

[Simon Green]

Comment on attachment 8355336 [details] [diff] [review]
report-v2.patch

This is a bug with this patch, which affected brc in production :(

It occurs when the brackets aren't closed. It can also happen when j_top is not AND.

Need to rethink the way to do this correctly. I'm thinking the best way is to set j_top to AND, adding [fot][123] as the extra values (as needed) and then moving everything else down (so j_top becomes f4=OP&j4= and [fov]1 becomes [fov]5, etc...)