926325 - TypeError: this.markup is undefined in InspectorPanel_onNewRoot in browser_inspector_bug_922125_destroy_on_navigate.js

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Description

[:Gijs (he/him)]

This test generally seems to make a lot of stuff unhappy:

16:58:16     INFO -  TEST-START | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js
16:58:16     INFO -  ++DOCSHELL 0x1677d4f10 == 139 [id = 4503]
16:58:16     INFO -  ++DOMWINDOW == 489 (0x16e4b4108) [serial = 11758] [outer = 0x0]
16:58:16     INFO -  ++DOMWINDOW == 490 (0x16578f0d8) [serial = 11759] [outer = 0x16e4b4108]
16:58:16     INFO -  [Parent 1042] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 264
16:58:16     INFO -  [Parent 1042] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 264
16:58:16     INFO -  ++DOCSHELL 0x17fec3450 == 140 [id = 4504]
16:58:16     INFO -  ++DOMWINDOW == 491 (0x17fec3c48) [serial = 11760] [outer = 0x0]
16:58:16     INFO -  ++DOMWINDOW == 492 (0x16623ce58) [serial = 11761] [outer = 0x17fec3c48]
16:58:16     INFO -  ++DOMWINDOW == 493 (0x17db76518) [serial = 11762] [outer = 0x17fec3c48]
16:58:17     INFO -  ++DOCSHELL 0x168b62bc0 == 141 [id = 4505]
16:58:17     INFO -  ++DOMWINDOW == 494 (0x168b61a48) [serial = 11763] [outer = 0x0]
16:58:17     INFO -  ++DOMWINDOW == 495 (0x168b57938) [serial = 11764] [outer = 0x168b61a48]
16:58:17     INFO -  ++DOCSHELL 0x17930e8b0 == 142 [id = 4506]
16:58:17     INFO -  ++DOMWINDOW == 496 (0x1793ec548) [serial = 11765] [outer = 0x0]
16:58:17     INFO -  ++DOMWINDOW == 497 (0x15e03d918) [serial = 11766] [outer = 0x1793ec548]
16:58:17     INFO -  ++DOCSHELL 0x16ed38040 == 143 [id = 4507]
16:58:17     INFO -  ++DOMWINDOW == 498 (0x171fc0108) [serial = 11767] [outer = 0x0]
16:58:17     INFO -  ++DOCSHELL 0x1681acbc0 == 144 [id = 4508]
16:58:17     INFO -  ++DOMWINDOW == 499 (0x15d303938) [serial = 11768] [outer = 0x0]
16:58:17     INFO -  ++DOCSHELL 0x15a700c80 == 145 [id = 4509]
16:58:17     INFO -  ++DOMWINDOW == 500 (0x171f6ef28) [serial = 11769] [outer = 0x0]
16:58:17     INFO -  ++DOCSHELL 0x165740ef0 == 146 [id = 4510]
16:58:17     INFO -  ++DOMWINDOW == 501 (0x15f892458) [serial = 11770] [outer = 0x0]
16:58:17     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | Console message: [JavaScript Warning: "XUL box for hbox element contained an inline span child, forcing all its children to be wrapped in a block." {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/inspector/highlighter.js" line: 482}]
16:58:17     INFO -  [Parent 1042] WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2349
16:58:17     INFO -  ++DOMWINDOW == 502 (0x17fea1e88) [serial = 11771] [outer = 0x171fc0108]
16:58:17     INFO -  ++DOMWINDOW == 503 (0x158de1738) [serial = 11772] [outer = 0x15d303938]
16:58:17     INFO -  ++DOMWINDOW == 504 (0x16817c228) [serial = 11773] [outer = 0x171f6ef28]
16:58:17     INFO -  ++DOMWINDOW == 505 (0x17de7efa8) [serial = 11774] [outer = 0x15f892458]
16:58:17     INFO -  JavaScript error: chrome://browser/content/devtools/theme-switching.js, line 38: window.matchMedia(...) is null
16:58:17     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | Console message: [JavaScript Error: "TypeError: window.matchMedia(...) is null" {file: "chrome://browser/content/devtools/theme-switching.js" line: 38}]
16:58:17     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | We have the test node on page 1
16:58:17     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | The markup-view is loaded
16:58:18     INFO -  JavaScript strict warning: chrome://browser/content/devtools/layoutview/view.js, line 199: anonymous function does not always return a value
16:58:18     INFO -  JavaScript strict warning: chrome://browser/content/devtools/layoutview/view.js, line 183: anonymous function does not always return a value
16:58:18     INFO -  console.error:
16:58:18     INFO -    Message: TypeError: node is null
16:58:18     INFO -    Stack:
16:58:18     INFO -      WalkerActor<.children<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:1164
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  WalkerActor<.children<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:1164
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  console.error:
16:58:18     INFO -    Message: TypeError: node is null
16:58:18     INFO -    Stack:
16:58:18     INFO -      WalkerActor<.children<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:1164
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  WalkerActor<.children<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:1164
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  console.error:
16:58:18     INFO -    Message: TypeError: node is null
16:58:18     INFO -    Stack:
16:58:18     INFO -      WalkerActor<.children<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:1164
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  WalkerActor<.children<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:1164
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  console.error:
16:58:18     INFO -    Message: TypeError: node is null
16:58:18     INFO -    Stack:
16:58:18     INFO -      WalkerActor<.children<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:1164
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  WalkerActor<.children<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js:1164
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  ++DOMWINDOW == 506 (0x17f4caa88) [serial = 11775] [outer = 0x16e4b4108]
16:58:18     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | Navigation to page 2 has started, the inspector should be empty
16:58:18     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | The markup-view is unloaded
16:58:18     INFO -  console.error:
16:58:18     INFO -    Message: TypeError: node is null
16:58:18     INFO -    Stack:
16:58:18     INFO -      PageStyleActor<.getApplied<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/styles.js:292
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  PageStyleActor<.getApplied<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/styles.js:292
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  console.error:
16:58:18     INFO -    Message: TypeError: node is null
16:58:18     INFO -    Stack:
16:58:18     INFO -      PageStyleActor<.getComputed<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/styles.js:142
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  PageStyleActor<.getComputed<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/styles.js:142
16:58:18     INFO -  actorProto/</handler@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js:906
16:58:18     INFO -  DSC_onPacket@resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js:1018
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js:258
16:58:18     INFO -  @resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js:75
16:58:18     INFO -  ++DOCSHELL 0x17f46b4d0 == 147 [id = 4511]
16:58:18     INFO -  ++DOMWINDOW == 507 (0x17f46bdb8) [serial = 11776] [outer = 0x0]
16:58:18     INFO -  [Parent 1042] WARNING: NS_ENSURE_TRUE(NS_SUCCEEDED(rv) && subjPrincipal) failed: file ../../../docshell/base/nsDocShell.cpp, line 8472
16:58:18     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | Console message: [JavaScript Warning: "TypeError: anonymous function does not always return a value" {file: "chrome://browser/content/devtools/layoutview/view.js" line: 199 column: 8 source: "        return;
16:58:18     INFO -  "}]
16:58:18     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | Console message: [JavaScript Warning: "TypeError: anonymous function does not always return a value" {file: "chrome://browser/content/devtools/layoutview/view.js" line: 183}]
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  [Parent 1042] WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2349
16:58:18     INFO -  ++DOMWINDOW == 508 (0x17f405c08) [serial = 11777] [outer = 0x17f46bdb8]
16:58:18     INFO -  console.error:
16:58:18     INFO -    unknownError
16:58:18     INFO -  ++DOCSHELL 0x1809581b0 == 148 [id = 4512]
16:58:18     INFO -  ++DOMWINDOW == 509 (0x180958bd8) [serial = 11778] [outer = 0x0]
16:58:18     INFO -  ++DOMWINDOW == 510 (0x180956b48) [serial = 11779] [outer = 0x180958bd8]
16:58:19     INFO -  [Parent 1042] WARNING: Subdocument container has no frame: file ../../../layout/base/nsDocumentViewer.cpp, line 2349
16:58:19     INFO -  JavaScript error: chrome://browser/content/devtools/theme-switching.js, line 38: window.matchMedia(...) is null
16:58:19     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | Console message: [JavaScript Error: "TypeError: window.matchMedia(...) is null" {file: "chrome://browser/content/devtools/theme-switching.js" line: 38}]
16:58:19     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | Navigation to page 2 was done, the inspector should be back up
16:58:19     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | We have the test node on page 2
16:58:19     INFO -  TEST-PASS | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | The markup-view is loaded
16:58:19     INFO -  [Parent 1042] WARNING: NS_ENSURE_TRUE(mMutable) failed: file ../../../../netwerk/base/src/nsSimpleURI.cpp, line 264
16:58:19     INFO -  TypeError: this.markup is undefined: InspectorPanel_onNewRoot/</<@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/inspector/inspector-panel.js:321
16:58:19     INFO -  @resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shared/event-emitter.js:63
16:58:19     INFO -  EventEmitter_emit@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/shared/event-emitter.js:110
16:58:19     INFO -  InspectorPanel__onMarkupFrameLoad@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/inspector/inspector-panel.js:619
16:58:19     INFO -  InspectorPanel_initMarkupPanel_onload@resource://gre/modules/commonjs/toolkit/loader.js -> resource:///modules/devtools/inspector/inspector-panel.js:601
16:58:19     INFO -  console.error:
16:58:19     INFO -  Object
16:58:19     INFO -    - prototype Object
16:58:19     INFO -      - columnNumber = 0
16:58:19     INFO -      - data = null
16:58:19     INFO -      - filename = resource://gre/modules/devtools/LayoutHelpers.jsm
16:58:19     INFO -      - inner = null
16:58:19     INFO -      - lineNumber = 20
16:58:19     INFO -      - location = {"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/devtools/LayoutHelpers.jsm","name":null,"lineNumber":20,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js","name":"DocumentWalker","lineNumber":2311,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js","name":"documentWalker","lineNumber":2292,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js","name":"WalkerActor<.children</filteredWalker","lineNumber":1160,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js","name":"WalkerActor<.children<","lineNumber":1165,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js","name":"actorProto/</handler","lineNumber":906,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js","name":"DSC_onPacket","lineNumber":1018,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js","name":null,"lineNumber":258,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js","name":null,"lineNumber":75,"sourceLine":null,"caller":{"language":0,"languageName":"C++","filename":null,"name":null,"lineNumber":0,"sourceLine":null,"caller":null}}}}}}}}}}
16:58:19     INFO -      - message = Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsIInterfaceRequestor.getInterface]
16:58:19     INFO -      - name = NS_NOINTERFACE
16:58:19     INFO -      - result = 2147500034
16:58:19     INFO -    - prototype Object
16:58:19     INFO -  console.error:
16:58:19     INFO -  Object
16:58:19     INFO -    - prototype Object
16:58:19     INFO -      - columnNumber = 0
16:58:19     INFO -      - data = null
16:58:19     INFO -      - filename = resource://gre/modules/devtools/LayoutHelpers.jsm
16:58:19     INFO -      - inner = null
16:58:19     INFO -      - lineNumber = 20
16:58:19     INFO -      - location = {"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/devtools/LayoutHelpers.jsm","name":null,"lineNumber":20,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js","name":"DocumentWalker","lineNumber":2311,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js","name":"documentWalker","lineNumber":2292,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js","name":"WalkerActor<.children</filteredWalker","lineNumber":1160,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/inspector.js","name":"WalkerActor<.children<","lineNumber":1165,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/protocol.js","name":"actorProto/</handler","lineNumber":906,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js","name":"DSC_onPacket","lineNumber":1018,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js","name":null,"lineNumber":258,"sourceLine":null,"caller":{"language":2,"languageName":"JavaScript","filename":"resource://gre/modules/devtools/dbg-server.jsm -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/DevToolsUtils.js","name":null,"lineNumber":75,"sourceLine":null,"caller":{"language":0,"languageName":"C++","filename":null,"name":null,"lineNumber":0,"sourceLine":null,"caller":null}}}}}}}}}}
16:58:19     INFO -      - message = Component returned failure code: 0x80004002 (NS_NOINTERFACE) [nsIInterfaceRequestor.getInterface]
16:58:19     INFO -      - name = NS_NOINTERFACE
16:58:19     INFO -      - result = 2147500034
16:58:19     INFO -    - prototype Object
16:58:20     INFO -  INFO TEST-END | chrome://mochitests/content/browser/browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js | finished in 3840ms

Comment 1

[:Gijs (he/him)]

Obviously, we could just chuck in a whole bunch of nullchecks, but I'm wondering if that's the Right Thing. Patrick, Mike, got ideas? The test really shouldn't be spamming errors the way it does, as that shows up in TBPL output when (other) tests fail and confuses people. :-)

Comment 2

[Patrick Brosset <:pbro>]

You're right, it's very confusing to have these errors. Sorry I didn't notice this behavior before landing the patch.
I think I may know where it's coming from.
Basically, the test case listens to the same "markuploaded" that the inspector does when we navigate to a new page. The test listener might be called before the inspector one, and since it uses it to end the tests, it might be responsible for the errors.

Comment 3

[Patrick Brosset <:pbro>]

Attachment: bug926325-markup-undefined-on-navigate.patch

Here's a patch that fixes the unwanted errors during test run.
Green try build: https://tbpl.mozilla.org/?tree=Try&rev=fceca1a0d637

Mike: this is a re-write of the test case I wrote for bug 922125 which, although was passing fine, generated a lot of js errors during its run.
These errors were due to the test not waiting for the right kind of events before navigating between pages and before ending the test.

I've also added a useful event to the inspector panel and documented all events.

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 817539 [details] [diff] [review]
bug926325-markup-undefined-on-navigate.patch

Review of attachment 817539 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/inspector/test/browser_inspector_bug_922125_destroy_on_navigate.js
@@ +27,3 @@
>  
> +  // open devtools panel
> +  deferred.promise.then(() => {

This seems strange, why not just:

let hostType = Toolbox.HostType.BOTTOM;
gDevTools.showToolbox(target, null, hostType).then(aToolbox => {
  toolbox = aToolbox;
  // select the inspector
  toolbox.selectTool("inspector").then(i => {

Comment 6

[Patrick Brosset <:pbro>]

Mike,

I was following the coding style of another existing test: browser_inspector_bug_840156_destroy_after_navigation.js
It seemed that using a promise to describe the test's steps was quite elegant.

As for the part you mentioned as strange, it is needed, because as you can see, `deffered` refers to a promise that is created line 18 and resolves when the page loads into the new tab.
So if I go ahead with your proposed changed, the toolbox will open before the page loads, which is not what I want.

You canceled the review, did you mean to r- instead?

Please let me know if I missed something?
Thanks

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Patrick Brosset from comment #6)
> You canceled the review, did you mean to r- instead?

I think some reviewers cancel instead of r- to be "nicer" about it, but it's effectively the same from what I've seen.

Comment 8

[Joe Walker [:jwalker]]

(In reply to J. Ryan Stinnett [:jryans] from comment #7)
> (In reply to Patrick Brosset from comment #6)
> > You canceled the review, did you mean to r- instead?
> 
> I think some reviewers cancel instead of r- to be "nicer" about it, but it's
> effectively the same from what I've seen.

I can't remember what the "you've been r-ed" message is, other than that I thought it was really badly worded, especially for a new contributor.

For longer time contributors, I tend to use r+ to mean "I'm happy if you fix my comments, don't ask me again". I use r:cancel to mean "I'll probably be happy if you fix my comments, but ask me again" and r- to mean "That's the wrong approach" or similar.

Comment 9

[Paul Rouget [:paul]]

Can someone confirm that this is the reason of all the failures we see in bug 823881? (see comments after the 10th of October).

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Note that bug 823881 is currently the #1 top orange on trunk.

Comment 11

[Patrick Brosset <:pbro>]

This bug doesn't block anything, it only happens to generate unfortunate JS errors when it runs, that's why, every time another test fails, it's a little bit confusing because you see these JS errors. However the test passes.

I have since then re-written the test so it doesn't generate these errors. Will be checked in as soon as possible.

Comment 12

[:Gijs (he/him)]

https://hg.mozilla.org/integration/fx-team/rev/82184578e17c

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/82184578e17c